Every mutating endpoint was reachable without authentication, so any visitor
could create, edit or delete posts, categories, tags, projects and about-me
records on the live site.
Security
- Split routes into an anonymous read-only group and a write group gated by
`auth:sanctum` + a new `admin` middleware.
- Add `is_admin` to users; Sanctum token support on the User model.
- Add AuthController (login / me / logout). The Sanctum token is delivered in
an httpOnly cookie and never returned in the JSON body, because the admin
panel reaches the API through a Next.js server-side proxy that breaks
Sanctum's first-party domain detection.
- AuthenticateAdminPanelSession promotes that cookie to a bearer header so
Sanctum's normal validation, expiry and revocation still apply.
- Remove the unauthenticated `/user/{id}` route, which exposed user emails.
- Non-admin accounts are refused at login and the failure shape is identical
to a bad password, so the endpoint cannot enumerate accounts.
- Fix `Route [login] not defined`: a non-JSON unauthenticated request resolved
a route that does not exist in this API-only app and returned 500.
- Reject invalid list query parameters with 422 instead of 500, and cap
per_page at 50 (`?per_page=100000` previously dumped whole tables).
Correctness
- Make the translation migration portable. It used MySQL-only JSON_OBJECTAGG,
which aborted all 29 tests during migration; the data collapse now runs in
PHP so it works on MySQL, MariaDB and SQLite.
- Add HasJsonTranslations trait providing the missing setTranslation(), which
made project create/update return 500, and replace five copy-pasted
getTranslation()/hasTranslation() bodies.
- Make posts.excerpt nullable to match StorePostRequest; omitting an excerpt
was a guaranteed SQL integrity error.
- Route the AboutMeController CRUD methods that existed but were never
registered.
- CategoryTest omitted a required description; fixed the test, the existing
schema and validation already agreed.
Tests: 83 passing / 126 assertions (was 29 failing / 0 assertions)
62 lines
1.7 KiB
PHP
62 lines
1.7 KiB
PHP
<?php
|
|
|
|
namespace App\Models\Concerns;
|
|
|
|
/**
|
|
* Locale-aware accessors for models that store translations in a single
|
|
* `translations` JSON column, shaped as:
|
|
*
|
|
* ['title' => ['fa' => '...', 'en' => '...']]
|
|
*
|
|
* The website models each had their own copy-pasted getTranslation()/hasTranslation()
|
|
* and no setTranslation() at all, which is why the project write endpoints
|
|
* returned HTTP 500 in production. This trait replaces the duplicated bodies
|
|
* and supplies the missing writer.
|
|
*/
|
|
trait HasJsonTranslations
|
|
{
|
|
public function getTranslation(string $key, string $locale, bool $useFallbackLocale = true): mixed
|
|
{
|
|
$translations = $this->translations;
|
|
|
|
if (! is_array($translations) || ! isset($translations[$key][$locale])) {
|
|
if (! $useFallbackLocale) {
|
|
return null;
|
|
}
|
|
|
|
$fallback = $this->getFallbackLocale();
|
|
|
|
return $translations[$key][$fallback] ?? null;
|
|
}
|
|
|
|
return $translations[$key][$locale];
|
|
}
|
|
|
|
/**
|
|
* Set a single locale's value. Call save() to persist.
|
|
*/
|
|
public function setTranslation(string $key, string $locale, mixed $value): static
|
|
{
|
|
$translations = $this->translations;
|
|
$translations = is_array($translations) ? $translations : [];
|
|
|
|
$translations[$key][$locale] = $value;
|
|
|
|
$this->translations = $translations;
|
|
|
|
return $this;
|
|
}
|
|
|
|
public function hasTranslation(string $key, string $locale): bool
|
|
{
|
|
$translations = $this->translations;
|
|
|
|
return is_array($translations) && isset($translations[$key][$locale]);
|
|
}
|
|
|
|
public function getFallbackLocale(): string
|
|
{
|
|
return (string) config('app.fallback_locale', 'en');
|
|
}
|
|
}
|