Files
canina/specs/042-blog-null-image/acceptance.md
2026-10-29 08:10:03 +00:00

3.2 KiB

Local acceptance (2026-10-29)

  • RED before source implementation: 2 files, 5 failed / 16 passed. Failures show global OG fallback, invented Article image and absent-card updating placeholder.
  • Targeted final: 5 files / 31 tests passed (exit 0).
  • Full storefront final: 100 files / 520 tests passed (exit 0); earlier run 99 files / 516 tests passed before adding BlogImage tests.
  • Typecheck exit 0. Production Next build exit 0; .next/BUILD_ID exists. Build logs include existing unavailable local API ECONNREFUSED during static generation; this is not backend connectivity acceptance.
  • Full ESLint has pre-existing lib/slug.ts:30 prefer-const error. Clean detached baseline 5642c1609c with identical node_modules reproduces it: 1 error / 501 warnings. Initial changed run 1 error / 505 warnings (before additional BlogImage test). No unrelated lint rewrite performed; full lint gate NOT green.
  • Real built Next server on loopback 3397 with read-only production API and Stage environment: actual article GET HTTP200, no og:image/twitter:image tags, Article JSON-LD no image, robots noindex/nofollow/nocache. Actual listing card: one match, “بدون تصویر”, zero img elements, zero updating claims. No article mutation; not a Stage deployment or browser visual QA.
  • Spec prerequisite script and git diff --check exit 0. Existing .specify/, evidence/ and graph cache dirty state preserved; graph query updated only its already-dirty query stamp.
  • Parent owns review, commit/push and Stage deployment/live verification. No push/deploy/production change here. Other apps/backend unchanged and not rebuilt.

Independent-review homepage whitespace correction (2026-10-29)

  • Regression uses the real BlogPreviewSection → BlogImage boundary with API response fixtures for null, undefined, empty string and whitespace, asserting “بدون تصویر” and no img. RED before source fix: 1 file, 1 failed / 8 passed; whitespace alone failed because BASE_DOMAIN was prefixed before trimming. Null/undefined/empty cases already passed.
  • Minimal correction trims imageUrl before presence/absolute-URL checks and BASE_DOMAIN prefixing.
  • Affected GREEN: 5 files / 35 tests passed (exit 0), including 4 new homepage cases. Full storefront: 100 files / 524 tests passed (exit 0). These supersede the earlier 31/520 counts above.
  • Typecheck exit 0; production Next build exit 0 (29/29 static pages generated). Existing local API ECONNREFUSED warnings remain; no backend connectivity or Stage acceptance claimed. Vite/Node deprecation and jsdom navigation/scroll warnings remain in test logs.
  • Follow-up logs (preserving earlier evidence): /opt/data/cache/scratch/null-blog-image/homepage-review-{red,green,full-tests,typecheck,build}.log; hashes/bytes in homepage-review-log-manifest.json beside this file. No commit, push, deploy or live mutations. Publisher files and pre-existing graph/.specify/evidence left untouched by this follow-up.

Logs: /opt/data/cache/scratch/null-blog-image/{red,green,targeted-final,full-tests-final,typecheck-final,build-final,lint,baseline-lint}.log; local-article.html and local-listing.html contain actual built HTTP responses. Baseline comparison checkout remains under scratch/baseline.