fix(blog): represent absent article imagery honestly
Deploy Canina / deploy (push) Successful in 3m12s
Deploy Canina / deploy (push) Successful in 3m12s
This commit is contained in:
1 parent
5642c1609c
commit
18094f91a6
17 files changed
+208
-24
No files matched your search
@@ -32,6 +32,37 @@ describe('BlogPostPage FAQPage Schema injection (SEO-P1-07)', () => {
|
||||
vi.unstubAllEnvs();
|
||||
});
|
||||
|
||||
it.each([null, undefined, ' '])('omits absent article imagery (%s) and overrides inherited social images', async (image) => {
|
||||
vi.stubGlobal('fetch', vi.fn().mockResolvedValue({ ok: true, json: async () => ({
|
||||
slug: 'no-image', title: 'No image', content: '<p>x</p>', imageUrl: image, ogImage: image,
|
||||
}) }));
|
||||
const metadata = await generateMetadata({ params: Promise.resolve({ slug: 'no-image' }) });
|
||||
expect((metadata.openGraph as any).images).toEqual([]);
|
||||
expect(metadata.twitter).toMatchObject({ card: 'summary', images: [] });
|
||||
expect(metadata.robots).toMatchObject({ index: false });
|
||||
const jsx = await BlogPostPage({ params: Promise.resolve({ slug: 'no-image' }) });
|
||||
const script: any = React.Children.toArray(jsx.props.children)[0];
|
||||
expect(JSON.parse(script.props.dangerouslySetInnerHTML.__html)).not.toHaveProperty('image');
|
||||
});
|
||||
|
||||
it.each([
|
||||
['/uploads/article.webp', null, '/uploads/article.webp'],
|
||||
['/uploads/article.webp', '/uploads/social.webp', '/uploads/social.webp'],
|
||||
[null, '/uploads/social.webp', '/uploads/social.webp'],
|
||||
])('retains only authored image/social precedence (%s, %s)', async (imageUrl, ogImage, social) => {
|
||||
vi.stubGlobal('fetch', vi.fn().mockResolvedValue({ ok: true, json: async () => ({
|
||||
slug: 'image', title: 'Image', imageAlt: 'Authored alt', content: '<p>x</p>', imageUrl, ogImage,
|
||||
}) }));
|
||||
const metadata = await generateMetadata({ params: Promise.resolve({ slug: 'image' }) });
|
||||
expect((metadata.openGraph as any).images).toEqual([{ url: social, alt: 'Authored alt' }]);
|
||||
expect(metadata.twitter).toMatchObject({ card: 'summary_large_image', images: [social] });
|
||||
const jsx = await BlogPostPage({ params: Promise.resolve({ slug: 'image' }) });
|
||||
const script: any = React.Children.toArray(jsx.props.children)[0];
|
||||
const article = JSON.parse(script.props.dangerouslySetInnerHTML.__html);
|
||||
if (imageUrl) expect(article.image).toEqual([`https://canina.ir${imageUrl}`]);
|
||||
else expect(article).not.toHaveProperty('image');
|
||||
});
|
||||
|
||||
it('injects FAQPage JSON-LD schema when article contains questions and answers', async () => {
|
||||
const blogData = {
|
||||
slug: 'joint-health',
|
||||
|
||||
@@ -81,7 +81,7 @@ export async function generateMetadata({ params }: { params: Promise<{ slug: str
|
||||
(typeof blog.content === 'string' ? blog.content.substring(0, 155).replace(/<[^>]+>/g, '') : '') ||
|
||||
config.defaultMetaDescription;
|
||||
const canonicalUrl = blog.canonicalUrl ? blog.canonicalUrl.replace(/\/+$/, '') : `${siteUrl}/blog/${slug}`;
|
||||
const ogImageUrl = blog.ogImage || blog.imageUrl || config.ogImageUrl;
|
||||
const ogImageUrl = blog.ogImage?.trim() || blog.imageUrl?.trim();
|
||||
const ogTitle = blog.ogTitle || title;
|
||||
const ogDesc = blog.ogDescription || description;
|
||||
|
||||
@@ -139,12 +139,8 @@ export async function generateMetadata({ params }: { params: Promise<{ slug: str
|
||||
openGraph: {
|
||||
title: ogTitle,
|
||||
description: ogDesc,
|
||||
images: [
|
||||
{
|
||||
url: ogImageUrl,
|
||||
alt: blog.imageAlt || blog.title || title,
|
||||
},
|
||||
],
|
||||
// Explicit empty arrays prevent inheriting the unrelated root image.
|
||||
images: ogImageUrl ? [{ url: ogImageUrl, alt: blog.imageAlt || blog.title || title }] : [],
|
||||
url: canonicalUrl,
|
||||
siteName: config.brandNameFa,
|
||||
type: "article",
|
||||
@@ -154,10 +150,10 @@ export async function generateMetadata({ params }: { params: Promise<{ slug: str
|
||||
tags: blog.tags?.map((t: any) => typeof t === 'string' ? t : t?.name).filter(Boolean) || [],
|
||||
},
|
||||
twitter: {
|
||||
card: "summary_large_image",
|
||||
card: ogImageUrl ? "summary_large_image" : "summary",
|
||||
title: ogTitle,
|
||||
description: ogDesc,
|
||||
images: [ogImageUrl],
|
||||
images: ogImageUrl ? [ogImageUrl] : [],
|
||||
},
|
||||
};
|
||||
}
|
||||
@@ -207,9 +203,7 @@ export default async function BlogPostPage({ params }: { params: Promise<{ slug:
|
||||
},
|
||||
headline: blog.title,
|
||||
description: blog.excerpt || blog.metaDescription || blog.title,
|
||||
image: blog.imageUrl
|
||||
? [blog.imageUrl.startsWith('http') ? blog.imageUrl : `${siteUrl}${blog.imageUrl.startsWith('/') ? '' : '/'}${blog.imageUrl}`]
|
||||
: [config.ogImageUrl.startsWith('http') ? config.ogImageUrl : `${siteUrl}${config.ogImageUrl.startsWith('/') ? '' : '/'}${config.ogImageUrl}`],
|
||||
...(blog.imageUrl?.trim() ? { image: [new URL(blog.imageUrl.trim(), `${siteUrl}/`).href] } : {}),
|
||||
datePublished: publishedIso,
|
||||
...(modifiedIso ? { dateModified: modifiedIso } : {}),
|
||||
author: authorSchema,
|
||||
|
||||
@@ -29,5 +29,6 @@ describe("blog page author identity", () => {
|
||||
|
||||
const props = blogPageSpy.mock.calls[0][0] as { blogs: Array<{ author: string }> };
|
||||
expect(props.blogs[0].author).toBe("کنینا");
|
||||
expect((props.blogs[0] as unknown as { image: string }).image).toBe('');
|
||||
});
|
||||
});
|
||||
@@ -64,7 +64,7 @@ async function getBlogs() {
|
||||
? new Date(String(b.createdAt)).toLocaleDateString('fa-IR')
|
||||
: '',
|
||||
readingTime: b.readingTime || 3,
|
||||
image: getMediaUrl(String(b.imageUrl || b.coverImage || '/assets/images/blog-placeholder.png')),
|
||||
image: getMediaUrl(String(b.imageUrl || b.coverImage || '')),
|
||||
imageAlt: b.imageAlt || b.title,
|
||||
author: authorName,
|
||||
content: String(b.content || ''),
|
||||
|
||||
@@ -0,0 +1,13 @@
|
||||
"use client";
|
||||
import React from "react";
|
||||
import SafeImage from "./SafeImage";
|
||||
|
||||
type BlogImageProps = React.ComponentProps<typeof SafeImage>;
|
||||
|
||||
/** An empty blog image slot is not an article photograph or a pending upload. */
|
||||
export default function BlogImage({ src, className, ...props }: BlogImageProps) {
|
||||
if (!src?.trim()) {
|
||||
return <div className={`flex items-center justify-center bg-medical-gray-100 text-medical-gray-500 text-xs ${className || ""}`}>بدون تصویر</div>;
|
||||
}
|
||||
return <SafeImage {...props} src={src} className={className} fallbackText="تصویر در دسترس نیست" fallbackAlt="" />;
|
||||
}
|
||||
@@ -25,7 +25,7 @@ import { Product } from "../lib/data/products";
|
||||
import { productService } from "../lib/services/productService";
|
||||
import { useRouter } from 'next/navigation';
|
||||
import Image from 'next/image';
|
||||
import SafeImage from './SafeImage';
|
||||
import BlogImage from './BlogImage';
|
||||
import { BLOG_TEAM_FALLBACK, publicationDate, validContentUpdatedAt, persianDate } from '../lib/blogDates';
|
||||
|
||||
export interface BlogCategory {
|
||||
@@ -310,7 +310,7 @@ export default function BlogPage({
|
||||
className="bg-white rounded-[3.5rem] overflow-hidden border border-medical-gray-200 shadow-2xl flex flex-col lg:flex-row cursor-pointer group hover:border-canina-blue/30 transition-all"
|
||||
>
|
||||
<div className="lg:w-1/2 aspect-video lg:aspect-auto relative overflow-hidden bg-medical-gray-100">
|
||||
<SafeImage
|
||||
<BlogImage
|
||||
src={featuredPost.image}
|
||||
alt={featuredPost.imageAlt || featuredPost.title}
|
||||
priority
|
||||
@@ -391,7 +391,7 @@ export default function BlogPage({
|
||||
>
|
||||
<div>
|
||||
<div className="aspect-[16/10] overflow-hidden relative bg-medical-gray-100">
|
||||
<SafeImage
|
||||
<BlogImage
|
||||
src={post.image}
|
||||
alt={post.imageAlt || post.title}
|
||||
sizes="(max-width: 768px) 100vw, (max-width: 1200px) 50vw, 33vw"
|
||||
|
||||
@@ -3,7 +3,7 @@ import React, { useEffect, useState } from "react";
|
||||
import Link from "next/link";
|
||||
import { BookOpen, Calendar, Eye, MessageSquare, ArrowLeft } from "lucide-react";
|
||||
import { motion } from "motion/react";
|
||||
import SafeImage from "./SafeImage";
|
||||
import BlogImage from "./BlogImage";
|
||||
import { useSettingsStore } from "../lib/store/settingsStore";
|
||||
import api, { BASE_DOMAIN } from "../lib/services/api";
|
||||
import { toPersian } from "../lib/utils";
|
||||
@@ -104,11 +104,12 @@ export default function BlogPreviewSection() {
|
||||
) : (
|
||||
<div className="flex md:grid md:grid-cols-2 lg:grid-cols-3 gap-4 md:gap-8 overflow-x-auto md:overflow-visible pb-4 md:pb-0 micro-hscroll -mx-4 px-4 md:mx-0 md:px-0 select-none snap-x snap-mandatory md:snap-none overscroll-x-contain">
|
||||
{blogs.map((blog, idx) => {
|
||||
const image = blog.imageUrl?.startsWith("http")
|
||||
? blog.imageUrl
|
||||
: blog.imageUrl
|
||||
? `${BASE_DOMAIN}${blog.imageUrl}`
|
||||
: "/assets/images/blog-placeholder.png";
|
||||
const imageUrl = blog.imageUrl?.trim();
|
||||
const image = imageUrl?.startsWith("http")
|
||||
? imageUrl
|
||||
: imageUrl
|
||||
? `${BASE_DOMAIN}${imageUrl}`
|
||||
: "";
|
||||
|
||||
const authorName = resolveBlogAuthor(blog.author);
|
||||
|
||||
@@ -126,7 +127,7 @@ export default function BlogPreviewSection() {
|
||||
className="bg-medical-gray-50/60 rounded-[1.5rem] sm:rounded-[2rem] border border-medical-gray-100 overflow-hidden hover:shadow-lg hover:-translate-y-1 transition-all flex flex-col group w-full"
|
||||
>
|
||||
<Link href={blogHref} className="block relative aspect-video w-full overflow-hidden bg-medical-gray-100">
|
||||
<SafeImage
|
||||
<BlogImage
|
||||
src={image}
|
||||
alt={blog.title}
|
||||
sizes="(max-width: 768px) 70vw, (max-width: 1200px) 50vw, 33vw"
|
||||
|
||||
@@ -12,6 +12,7 @@ interface SafeImageProps extends Omit<React.ImgHTMLAttributes<HTMLImageElement>,
|
||||
className?: string;
|
||||
imgClassName?: string;
|
||||
fallbackText?: string;
|
||||
fallbackAlt?: string;
|
||||
priority?: boolean;
|
||||
sizes?: string;
|
||||
quality?: number;
|
||||
@@ -25,6 +26,7 @@ export default function SafeImage({
|
||||
className,
|
||||
imgClassName,
|
||||
fallbackText = "در حال بروزرسانی تصویر...",
|
||||
fallbackAlt,
|
||||
priority = false,
|
||||
sizes = "(max-width: 640px) 200px, (max-width: 1024px) 300px, 400px",
|
||||
quality = 75,
|
||||
@@ -64,7 +66,7 @@ export default function SafeImage({
|
||||
{logoUrl ? (
|
||||
<Image
|
||||
src={logoUrl}
|
||||
alt={alt || "Canina"}
|
||||
alt={fallbackAlt ?? (alt || "Canina")}
|
||||
width={80}
|
||||
height={80}
|
||||
className="w-12 h-12 object-contain opacity-70 mb-1"
|
||||
|
||||
@@ -0,0 +1,22 @@
|
||||
import React from 'react';
|
||||
import { afterEach, describe, expect, it, vi } from 'vitest';
|
||||
import { cleanup, fireEvent, render, screen } from '@testing-library/react';
|
||||
import BlogImage from '../BlogImage';
|
||||
vi.mock('next/image', () => ({ default: ({ priority, unoptimized, ...props }: any) => <img {...props} /> }));
|
||||
vi.mock('../../lib/store/settingsStore', () => ({ useSettingsStore: (select: any) => select({ getText: () => '/logo.png' }) }));
|
||||
afterEach(cleanup);
|
||||
describe('BlogImage', () => {
|
||||
it.each([undefined, '', ' '])('renders absent image (%s) as neutral text, never article photo', (src) => {
|
||||
render(<BlogImage src={src} alt="Article title" />);
|
||||
expect(screen.getByText('بدون تصویر')).toBeDefined();
|
||||
expect(screen.queryByRole('img')).toBeNull();
|
||||
});
|
||||
it('preserves a real authored image and uses decorative logo on load failure, not title alt or updating claim', () => {
|
||||
render(<BlogImage src="/image.jpg" alt="Authored image" />);
|
||||
fireEvent.error(screen.getByRole('img', { name: 'Authored image' }));
|
||||
expect(screen.getByText('تصویر در دسترس نیست')).toBeDefined();
|
||||
expect(screen.queryByRole('img')).toBeNull();
|
||||
expect(document.querySelector('img')?.getAttribute('alt')).toBe('');
|
||||
expect(screen.queryByText(/در حال بروزرسانی/)).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -20,6 +20,7 @@ const blogs=[{id:'1',slug:'joint',title:'Joint article',excerpt:'Mobility guide'
|
||||
const categories=[{id:'joints',name:'Joints',slug:'joints'},{id:'skin',name:'Skin',slug:'skin'}];
|
||||
beforeEach(()=>vi.clearAllMocks());
|
||||
describe('BlogPage',()=>{
|
||||
it('shows honest image absence on featured and regular cards without title-alt placeholders',()=>{render(<BlogPage blogs={blogs.map(b=>({...b,image:''}))}/>);expect(screen.getAllByText('بدون تصویر')).toHaveLength(2);expect(screen.queryByRole('img')).not.toBeInTheDocument();expect(screen.queryByText(/در حال بروزرسانی تصویر/)).not.toBeInTheDocument();});
|
||||
it('renders featured and regular posts as semantic links',()=>{render(<BlogPage blogs={blogs} categories={categories}/>);expect(screen.getAllByRole('heading',{level:2})[0]).toHaveTextContent('Skin article');expect(screen.getByRole('link',{name:/Skin article/})).toHaveAttribute('href','/blog/skin');expect(screen.getByRole('link',{name:/Joint article/})).toHaveAttribute('href','/blog/joint');});
|
||||
it('labels publication, including a same-day material update, author and stable team on featured and regular cards',()=>{const fresh=[{...blogs[0],publishedAt:'2026-01-01T08:00:00Z',contentUpdatedAt:'2026-01-02T08:00:00Z',authorTeam:'Clinical'}, {...blogs[1],publishedAt:'2026-01-02T08:00:00Z',contentUpdatedAt:'2026-01-02T12:00:00Z'}];render(<BlogPage blogs={fresh} categories={categories}/>);expect(screen.getAllByText(/تاریخ انتشار/)).toHaveLength(2);expect(screen.getAllByText(/آخرین بهروزرسانی/)).toHaveLength(2);expect(screen.getAllByText(/نویسنده:/)).toHaveLength(2);expect(screen.getByText(/تیم: Clinical/)).toBeInTheDocument();expect(screen.getByText(/تیم: پژوهش و محتوای علمی کنینا/)).toBeInTheDocument();expect(document.querySelectorAll('time[datetime]').length).toBeGreaterThanOrEqual(4);});
|
||||
it('stacks author and team on separate non-wrapping rows and keeps featured action on one line',()=>{render(<BlogPage blogs={blogs} categories={categories}/>);const featuredMeta=screen.getByTestId('featured-attribution');expect(featuredMeta).toHaveClass('flex-col');expect(screen.getByTestId('featured-read-more')).toHaveClass('whitespace-nowrap');const regularMeta=screen.getByTestId('regular-attribution-1');expect(regularMeta).toHaveClass('flex-col');expect(regularMeta.children).toHaveLength(2);expect(regularMeta.children[0]).toHaveClass('whitespace-nowrap');expect(regularMeta.children[1]).toHaveClass('whitespace-nowrap');});
|
||||
|
||||
@@ -123,6 +123,24 @@ describe("BlogPreviewSection Component", () => {
|
||||
expect(link2).toHaveAttribute("href", "/blog/cat-hair-loss-solutions");
|
||||
});
|
||||
|
||||
it.each([null, undefined, "", " "])(
|
||||
"renders neutral absence without an img for homepage imageUrl=%j",
|
||||
async (imageUrl) => {
|
||||
vi.mocked(api.get).mockResolvedValueOnce({
|
||||
data: { blogs: [{
|
||||
id: "no-image", slug: "no-image", title: "مقاله بدون عکس",
|
||||
content: "", viewCount: 0, createdAt: "2026-01-01T00:00:00Z", imageUrl,
|
||||
}] },
|
||||
});
|
||||
const { container } = render(<BlogPreviewSection />);
|
||||
|
||||
expect(await screen.findByText("مقاله بدون عکس")).toBeInTheDocument();
|
||||
expect(screen.getByText("بدون تصویر")).toBeInTheDocument();
|
||||
expect(container.querySelector("img")).toBeNull();
|
||||
expect(api.get).toHaveBeenCalledWith("/blogs/homepage");
|
||||
},
|
||||
);
|
||||
|
||||
it("uses publication freshness and explicit byline labels on homepage cards", async () => {
|
||||
vi.mocked(api.get).mockResolvedValueOnce({ data: { blogs: [{ id:"b",slug:"b",title:"B",content:"",viewCount:0,createdAt:"2026-01-01T00:00:00Z",publishedAt:"2026-01-01T00:00:00Z",contentUpdatedAt:"2026-01-02T00:00:00Z",authorTeam:"Science" }] } });
|
||||
render(<BlogPreviewSection />);
|
||||
|
||||
@@ -0,0 +1,18 @@
|
||||
# Local acceptance (2026-10-29)
|
||||
- RED before source implementation: 2 files, 5 failed / 16 passed. Failures show global OG fallback, invented Article image and absent-card updating placeholder.
|
||||
- Targeted final: 5 files / 31 tests passed (exit 0).
|
||||
- Full storefront final: 100 files / 520 tests passed (exit 0); earlier run 99 files / 516 tests passed before adding BlogImage tests.
|
||||
- Typecheck exit 0. Production Next build exit 0; .next/BUILD_ID exists. Build logs include existing unavailable local API ECONNREFUSED during static generation; this is not backend connectivity acceptance.
|
||||
- Full ESLint has pre-existing lib/slug.ts:30 prefer-const error. Clean detached baseline 5642c1609c with identical node_modules reproduces it: 1 error / 501 warnings. Initial changed run 1 error / 505 warnings (before additional BlogImage test). No unrelated lint rewrite performed; full lint gate NOT green.
|
||||
- Real built Next server on loopback 3397 with read-only production API and Stage environment: actual article GET HTTP200, no og:image/twitter:image tags, Article JSON-LD no image, robots noindex/nofollow/nocache. Actual listing card: one match, “بدون تصویر”, zero img elements, zero updating claims. No article mutation; not a Stage deployment or browser visual QA.
|
||||
- Spec prerequisite script and git diff --check exit 0. Existing .specify/, evidence/ and graph cache dirty state preserved; graph query updated only its already-dirty query stamp.
|
||||
- Parent owns review, commit/push and Stage deployment/live verification. No push/deploy/production change here. Other apps/backend unchanged and not rebuilt.
|
||||
|
||||
## Independent-review homepage whitespace correction (2026-10-29)
|
||||
- Regression uses the real BlogPreviewSection → BlogImage boundary with API response fixtures for null, undefined, empty string and whitespace, asserting “بدون تصویر” and no img. RED before source fix: 1 file, 1 failed / 8 passed; whitespace alone failed because BASE_DOMAIN was prefixed before trimming. Null/undefined/empty cases already passed.
|
||||
- Minimal correction trims imageUrl before presence/absolute-URL checks and BASE_DOMAIN prefixing.
|
||||
- Affected GREEN: 5 files / 35 tests passed (exit 0), including 4 new homepage cases. Full storefront: 100 files / 524 tests passed (exit 0). These supersede the earlier 31/520 counts above.
|
||||
- Typecheck exit 0; production Next build exit 0 (29/29 static pages generated). Existing local API ECONNREFUSED warnings remain; no backend connectivity or Stage acceptance claimed. Vite/Node deprecation and jsdom navigation/scroll warnings remain in test logs.
|
||||
- Follow-up logs (preserving earlier evidence): `/opt/data/cache/scratch/null-blog-image/homepage-review-{red,green,full-tests,typecheck,build}.log`; hashes/bytes in `homepage-review-log-manifest.json` beside this file. No commit, push, deploy or live mutations. Publisher files and pre-existing graph/.specify/evidence left untouched by this follow-up.
|
||||
|
||||
Logs: /opt/data/cache/scratch/null-blog-image/{red,green,targeted-final,full-tests-final,typecheck-final,build-final,lint,baseline-lint}.log; local-article.html and local-listing.html contain actual built HTTP responses. Baseline comparison checkout remains under scratch/baseline.
|
||||
@@ -0,0 +1,22 @@
|
||||
{
|
||||
"/opt/data/cache/scratch/null-blog-image/homepage-review-build.log": {
|
||||
"sha256": "c6f7615cf20a4671d723853f6e032ddcc270b4b06b21c5a1418ff618dd3a5915",
|
||||
"bytes": 9535
|
||||
},
|
||||
"/opt/data/cache/scratch/null-blog-image/homepage-review-full-tests.log": {
|
||||
"sha256": "3cb764159d4535e057c6c43e5afb93e5d504da5bbfe21bd7c296b67204f069e9",
|
||||
"bytes": 1303
|
||||
},
|
||||
"/opt/data/cache/scratch/null-blog-image/homepage-review-green.log": {
|
||||
"sha256": "9a8de6a8cff6428887ba66ba89ecb3bf0918fcb1cf4d22e8ba8b4420b3bcfe08",
|
||||
"bytes": 1118
|
||||
},
|
||||
"/opt/data/cache/scratch/null-blog-image/homepage-review-red.log": {
|
||||
"sha256": "4ee9562e75a00c05c57790e6cb24c30eb0b41dc94212d584b4b1e179925c7607",
|
||||
"bytes": 16479
|
||||
},
|
||||
"/opt/data/cache/scratch/null-blog-image/homepage-review-typecheck.log": {
|
||||
"sha256": "01a354bc37e7eadc6b02c605d1127d41972d9bc5eaa340d012b8f72a5054a693",
|
||||
"bytes": 71
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,46 @@
|
||||
{
|
||||
"typecheck.log": {
|
||||
"sha256": "01a354bc37e7eadc6b02c605d1127d41972d9bc5eaa340d012b8f72a5054a693",
|
||||
"bytes": 71
|
||||
},
|
||||
"build-final.log": {
|
||||
"sha256": "0c7a91cf981e6b845d251ad4b18ab927513c67c7d089cb9e81c8d26bfb2fcddb",
|
||||
"bytes": 9536
|
||||
},
|
||||
"targeted-final.log": {
|
||||
"sha256": "689fc916d06dbe928eaa737da96c1fd7e87a11826419d59c59b55a48a7acce3f",
|
||||
"bytes": 1119
|
||||
},
|
||||
"lint.log": {
|
||||
"sha256": "06432936df0856652ef83844c2f447cbe4801dc8e104e43d96752ba2c54469c2",
|
||||
"bytes": 118367
|
||||
},
|
||||
"green.log": {
|
||||
"sha256": "fdd5788d25bb71677f416b10be36e29c01d537801c989932dd00d53fe83c5b0d",
|
||||
"bytes": 1000
|
||||
},
|
||||
"typecheck-final.log": {
|
||||
"sha256": "01a354bc37e7eadc6b02c605d1127d41972d9bc5eaa340d012b8f72a5054a693",
|
||||
"bytes": 71
|
||||
},
|
||||
"baseline-lint.log": {
|
||||
"sha256": "a783d7f46dfc7abada7556c9689edb3f3fac06caa080713f74490d79fcf21655",
|
||||
"bytes": 116579
|
||||
},
|
||||
"build.log": {
|
||||
"sha256": "7180f9b437c558b58c87390c179a8d3d654f049c6cbabd8b63495863564c5323",
|
||||
"bytes": 9536
|
||||
},
|
||||
"red.log": {
|
||||
"sha256": "ccbcf8b01d89e339f3c7523e5ea7ba481efc92da09d36c23410ba574a4daa594",
|
||||
"bytes": 12855
|
||||
},
|
||||
"full-tests-final.log": {
|
||||
"sha256": "a82453ff8019df80a45081eb2cf809a6a917f5f88b92f9d4479f9032ab00e280",
|
||||
"bytes": 1303
|
||||
},
|
||||
"full-tests.log": {
|
||||
"sha256": "4e6342a720abb210a154871f5b908dccd6b0ef2332e027411a1d85686bc82537",
|
||||
"bytes": 1301
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,6 @@
|
||||
# Plan and impact
|
||||
Baseline develop 5642c1609c7ab62b10530d8f453c4915988787c8; existing dirty graphify-out/cache/last_query_stamp and untracked .specify/, evidence/ preserved.
|
||||
Graphify BFS query before direct source: Blog -> getBlogs -> BlogPage, getSeoConfig/getMediaUrl/SafeImage. Graph SHA256 6a73473cee9e207543fdeeb668bea544f766200a1b16b8a3a9ce18d4e42e51af; 4304 nodes; build/SHA binding unverified, navigation only. Direct source confirms root metadata image inheritance, slug global fallback, listing synthetic placeholder and SafeImage updating claim. Scope: slug metadata/schema, list mapping and blog-only image wrapper used by public cards. Leave global SafeImage/product semantics unchanged.
|
||||
Independent-review follow-up: homepage normalization must trim imageUrl before checking presence or prefixing BASE_DOMAIN. Add parameterized homepage integration coverage through the real BlogImage for null, undefined, empty and whitespace values, expecting “بدون تصویر” and no img; observe RED before minimal normalization fix, then rerun affected/full storefront tests, typecheck and build. Read-only graph neighborhood inspection retains the graph hash above; HomeClient imports BlogPreviewSection, which uses the API and blog wrapper (graph still shows older SafeImage import, so navigation only). Preserve all pre-existing dirty files and publisher ownership; no commit/push/deploy.
|
||||
|
||||
Use explicit [] social images to suppress root defaults. Blog-only wrapper delegates valid images to SafeImage but supplies neutral fallback text and decorative fallback alt; absent images use text not an img. Confirm direct sources/tests rather than treating graph as current evidence.
|
||||
@@ -0,0 +1,3 @@
|
||||
# Honest absence of blog imagery
|
||||
Null, omitted or blank article image fields must not invent editorial photography or suggest an upload is pending. Article JSON-LD omits image without imageUrl. Social metadata uses authored ogImage then imageUrl, otherwise explicitly empty image arrays (override root defaults) and summary card. Featured/regular and home blog cards show neutral text “بدون تصویر” with no article-title image alt when absent; genuine images retain alt. No content/database mutations or global fallback changes. Stage noindex remains.
|
||||
Acceptance: reproduce null metadata/schema and card semantics RED; preserve real image/social override precedence; typecheck, lint, full storefront tests and production build. Parent alone pushes/deploys Stage; Production excluded.
|
||||
@@ -0,0 +1,6 @@
|
||||
# Tasks
|
||||
- [x] Reproduce absent metadata/schema and featured/regular card behavior before implementation.
|
||||
- [x] Implement bounded blog image absence semantics; preserve supplied imagery and Stage robots.
|
||||
- [x] Run targeted/full storefront tests, typecheck, lint, production build; record actual results.
|
||||
- [x] Independent-review homepage whitespace regression RED (1 failed / 8 passed), minimal trim-before-prefix fix, affected GREEN (35 tests), full storefront (524 tests), typecheck/build; append actual evidence without replacing earlier logs.
|
||||
- [ ] Parent review/push and Stage live acceptance remain separate; do not deploy here.
|
||||
Reference in new issue
Block a user