feat(admin): integrate paginated Hermes records and authoritative task details
This commit is contained in:
1 parent
3b05fe2e85
commit
5550c80a75
12 files changed
+182
-36
No files matched your search
@@ -0,0 +1,10 @@
|
||||
import type { PageMeta } from '../services/hermesApi';
|
||||
export default function HermesPagination({ meta, loading, onPage }: { meta: PageMeta | null; loading: boolean; onPage: (page: number) => void }) {
|
||||
if (!meta) return null;
|
||||
return <nav aria-label="صفحهبندی" className="flex flex-wrap items-center gap-4 rounded-xl border p-4 bg-white">
|
||||
<span>تعداد کل: {meta.total}</span>
|
||||
<button disabled={loading || !meta.hasPrevPage} onClick={() => onPage(meta.page - 1)}>قبلی</button>
|
||||
<span>صفحه {meta.page} از {meta.totalPages}</span>
|
||||
<button disabled={loading || !meta.hasNextPage} onClick={() => onPage(meta.page + 1)}>بعدی</button>
|
||||
</nav>;
|
||||
}
|
||||
@@ -0,0 +1,10 @@
|
||||
import { cleanup, render, screen } from '@testing-library/react';
|
||||
import { afterEach, expect, it } from 'vitest';
|
||||
import HermesSource, { safeHttpUrl } from './HermesSource';
|
||||
afterEach(cleanup);
|
||||
it.each(['javascript:alert(1)', 'data:text/html,hi', 'canina://internal/1', 'not a URL'])('does not link unsafe/unavailable source %s', (source) => {
|
||||
expect(safeHttpUrl(source)).toBeUndefined();
|
||||
render(<HermesSource source={source} />);
|
||||
expect(screen.queryByRole('link')).toBeNull();
|
||||
expect(screen.getByText(/پیوند منبع در دسترس نیست/)).toBeDefined();
|
||||
});
|
||||
@@ -0,0 +1,9 @@
|
||||
export function safeHttpUrl(value?: string): string | undefined {
|
||||
if (!value) return undefined;
|
||||
try { const url = new URL(value); return ['http:', 'https:'].includes(url.protocol) ? url.href : undefined; }
|
||||
catch { return undefined; }
|
||||
}
|
||||
export default function HermesSource({ source }: { source?: string }) {
|
||||
const url = safeHttpUrl(source);
|
||||
return <span>منبع داده: {source || 'ناموجود'} — {url ? <a href={url} target="_blank" rel="noopener noreferrer" className="text-blue-700 underline">مشاهده منبع</a> : 'پیوند منبع در دسترس نیست'}</span>;
|
||||
}
|
||||
@@ -50,10 +50,28 @@ describe('CorporateTasksPage', () => {
|
||||
beforeEach(() => {
|
||||
vi.resetAllMocks();
|
||||
vi.mocked(hermesApi.getTasks).mockResolvedValue(mockTaskResponse);
|
||||
vi.mocked(hermesApi.getTaskById).mockResolvedValue(mockTaskResponse.data[0]);
|
||||
});
|
||||
|
||||
afterEach(cleanup);
|
||||
|
||||
it('loads authoritative task detail from the API', async () => {
|
||||
render(<CorporateTasksPage />);
|
||||
fireEvent.click(await screen.findByRole('button', { name: /جزئیات و مکالمات/ }));
|
||||
await waitFor(() => expect(hermesApi.getTaskById).toHaveBeenCalledWith('t-1', expect.any(AbortSignal)));
|
||||
});
|
||||
|
||||
it('shows creation failure and retains entered directive', async () => {
|
||||
vi.mocked(hermesApi.createCeoTask).mockRejectedValue(new Error('not saved'));
|
||||
render(<CorporateTasksPage />);
|
||||
fireEvent.click(await screen.findByRole('button', { name: /ثبت دستور فوری مدیرعامل/ }));
|
||||
fireEvent.change(screen.getByPlaceholderText(/مثال: آپدیت فوری/), {target:{value:'retained directive'}});
|
||||
fireEvent.change(screen.getByPlaceholderText(/دقیقاً چه کاری/), {target:{value:'acceptance'}});
|
||||
fireEvent.click(screen.getByRole('button', {name:/ثبت با اولویت فوری صف/}));
|
||||
expect(await screen.findByRole('alert')).toHaveTextContent('ثبت دستور ناموفق');
|
||||
expect(screen.getByPlaceholderText(/مثال: آپدیت فوری/)).toHaveValue('retained directive');
|
||||
});
|
||||
|
||||
it('renders task list with department badges, task codes, and filter elements', async () => {
|
||||
render(<CorporateTasksPage />);
|
||||
expect(await screen.findByText('مدیریت و پایش وظایف دپارتمانها')).toBeDefined();
|
||||
|
||||
@@ -1,5 +1,6 @@
|
||||
import { useEffect, useRef, useState } from 'react';
|
||||
import { createPortal } from 'react-dom';
|
||||
import { safeHttpUrl } from '../components/HermesSource';
|
||||
import {
|
||||
ListOrdered,
|
||||
Search,
|
||||
@@ -68,6 +69,22 @@ export default function CorporateTasksPage() {
|
||||
// Detail Modal
|
||||
const [selectedTask, setSelectedTask] = useState<CorporateTaskItem | null>(null);
|
||||
|
||||
const [detailId, setDetailId] = useState<string | null>(null);
|
||||
const [detailLoading, setDetailLoading] = useState(false);
|
||||
const [detailError, setDetailError] = useState(false);
|
||||
useEffect(() => {
|
||||
if (!detailId) return;
|
||||
const controller = new AbortController();
|
||||
setDetailLoading(true);
|
||||
setDetailError(false);
|
||||
setSelectedTask(null);
|
||||
hermesApi.getTaskById(detailId, controller.signal)
|
||||
.then((item) => { if (!controller.signal.aborted) setSelectedTask(item); })
|
||||
.catch(() => { if (!controller.signal.aborted) setDetailError(true); })
|
||||
.finally(() => { if (!controller.signal.aborted) setDetailLoading(false); });
|
||||
return () => controller.abort();
|
||||
}, [detailId]);
|
||||
|
||||
// Fast-track CEO Directive Modal
|
||||
const [ceoModalOpen, setCeoModalOpen] = useState(false);
|
||||
const [ceoTitle, setCeoTitle] = useState('');
|
||||
@@ -185,7 +202,7 @@ export default function CorporateTasksPage() {
|
||||
<div className="flex items-center justify-between">
|
||||
<span className="text-xs font-bold text-slate-600">{cfg.label} (این صفحه)</span>
|
||||
<span className={`text-xs px-2 py-0.5 rounded-md font-bold ${cfg.bg} ${cfg.text}`}>
|
||||
{count}
|
||||
{error || loading ? 'ناموجود' : count}
|
||||
</span>
|
||||
</div>
|
||||
</div>
|
||||
@@ -303,7 +320,7 @@ export default function CorporateTasksPage() {
|
||||
</tr>
|
||||
</thead>
|
||||
<tbody className="divide-y divide-slate-100 block md:table-row-group">
|
||||
{!loading && tasks.length === 0 && (
|
||||
{!loading && !error && tasks.length === 0 && (
|
||||
<tr className="block md:table-row">
|
||||
<td colSpan={7} className="p-12 text-center text-slate-500 text-sm block md:table-cell">
|
||||
<div className="max-w-xs mx-auto space-y-2">
|
||||
@@ -416,7 +433,7 @@ export default function CorporateTasksPage() {
|
||||
<td className="block md:table-cell p-0 md:p-3.5 md:pl-5 pt-3 md:pt-3.5 align-top">
|
||||
<button
|
||||
className="w-full md:w-auto inline-flex items-center justify-center gap-2 px-3.5 py-2 rounded-xl text-xs sm:text-sm font-semibold text-slate-700 bg-slate-100 hover:bg-slate-200 border border-slate-200 shadow-sm active:scale-[0.98] transition-all cursor-pointer"
|
||||
onClick={() => setSelectedTask(task)}
|
||||
onClick={() => setDetailId(task.id)}
|
||||
>
|
||||
<Eye className="w-4 h-4 text-slate-600" />
|
||||
<span>جزئیات و مکالمات</span>
|
||||
@@ -430,7 +447,7 @@ export default function CorporateTasksPage() {
|
||||
</div>
|
||||
|
||||
{/* صفحهبندی */}
|
||||
<nav
|
||||
{!error && !loading && <nav
|
||||
aria-label="صفحهبندی"
|
||||
className="flex flex-col sm:flex-row items-center justify-between gap-4 p-4 bg-white rounded-2xl border border-slate-200/90 shadow-sm text-sm text-slate-600"
|
||||
>
|
||||
@@ -456,8 +473,10 @@ export default function CorporateTasksPage() {
|
||||
<ChevronLeft className="w-4 h-4" />
|
||||
</button>
|
||||
</div>
|
||||
</nav>
|
||||
</nav>}
|
||||
|
||||
{detailLoading && <p role="status">در حال دریافت جزئیات تسک...</p>}
|
||||
{detailError && <div role="alert">جزئیات در دسترس نیست. <button onClick={() => { setDetailId(null); setDetailError(false); }}>بستن</button></div>}
|
||||
{/* مودال جزئیات و ریز مکالمات ایجنتها */}
|
||||
{selectedTask &&
|
||||
createPortal(
|
||||
@@ -485,7 +504,7 @@ export default function CorporateTasksPage() {
|
||||
</div>
|
||||
<button
|
||||
className="p-2 rounded-xl text-slate-500 hover:text-slate-800 hover:bg-slate-200/80 transition-colors cursor-pointer"
|
||||
onClick={() => setSelectedTask(null)}
|
||||
onClick={() => { setSelectedTask(null); setDetailId(null); }}
|
||||
>
|
||||
<X className="w-5 h-5" />
|
||||
</button>
|
||||
@@ -497,11 +516,11 @@ export default function CorporateTasksPage() {
|
||||
<div className="bg-slate-50 rounded-2xl p-4 border border-slate-200 space-y-2">
|
||||
<h3 className="text-xs font-bold text-slate-600">هدف و شرح اقدام:</h3>
|
||||
<p className="text-sm text-slate-800 leading-relaxed">{selectedTask.description}</p>
|
||||
{selectedTask.deliverableUrl && (
|
||||
{safeHttpUrl(selectedTask.deliverableUrl) && (
|
||||
<div className="pt-2 border-t border-slate-200/60 flex items-center gap-2">
|
||||
<span className="text-xs font-bold text-slate-600">خروجی زنده:</span>
|
||||
<a
|
||||
href={selectedTask.deliverableUrl}
|
||||
href={safeHttpUrl(selectedTask.deliverableUrl)}
|
||||
target="_blank"
|
||||
rel="noopener noreferrer"
|
||||
className="inline-flex items-center gap-1 text-xs font-bold text-blue-700 underline"
|
||||
@@ -522,8 +541,7 @@ export default function CorporateTasksPage() {
|
||||
</h3>
|
||||
</div>
|
||||
|
||||
{createError && <p role="alert">ثبت دستور ناموفق بود؛ ثبت در سرور تأیید نشد.</p>}
|
||||
<div className="space-y-3">
|
||||
<div className="space-y-3">
|
||||
{selectedTask.logs && selectedTask.logs.length > 0 ? (
|
||||
selectedTask.logs.map((log, idx) => {
|
||||
const isCeo = log.speaker === 'CEO';
|
||||
|
||||
@@ -0,0 +1,27 @@
|
||||
import { cleanup, fireEvent, render, screen, waitFor } from '@testing-library/react';
|
||||
import { afterEach, beforeEach, expect, it, vi } from 'vitest';
|
||||
import Market from './MarketIntelligencePage';
|
||||
import Roadmap from './MonthlyRoadmapPage';
|
||||
import { hermesApi } from '../services/hermesApi';
|
||||
vi.mock('../services/hermesApi', () => ({ hermesApi: { getMarketInsights: vi.fn(), getMonthlyRoadmap: vi.fn() } }));
|
||||
afterEach(cleanup);
|
||||
const meta = { total: 42, page: 1, limit: 10, totalPages: 5, hasNextPage: true, hasPrevPage: false };
|
||||
beforeEach(() => vi.resetAllMocks());
|
||||
it.each([{ Component: Market, method: 'getMarketInsights' as const }, { Component: Roadmap, method: 'getMonthlyRoadmap' as const }])('uses server metadata and requests next page for $method', async ({ Component, method }) => {
|
||||
vi.mocked(hermesApi[method]).mockResolvedValue({ data: [], meta });
|
||||
render(<Component />);
|
||||
expect(await screen.findByText(/تعداد کل: 42/)).toBeDefined();
|
||||
fireEvent.click(screen.getByRole('button', { name: 'بعدی' }));
|
||||
await waitFor(() => expect(hermesApi[method]).toHaveBeenLastCalledWith(expect.objectContaining({ page: 2, limit: 10 }), expect.any(AbortSignal)));
|
||||
});
|
||||
it('shows explicit unavailable state with no fake summary', async () => {
|
||||
vi.mocked(hermesApi.getMarketInsights).mockRejectedValue(new Error('offline'));
|
||||
render(<Market />);
|
||||
expect(await screen.findByRole('alert')).toBeDefined();
|
||||
expect(screen.queryByText('مکمل مفاصل و ضدآرتروز')).toBeNull();
|
||||
});
|
||||
it('links only a supplied HTTP source', async () => {
|
||||
vi.mocked(hermesApi.getMarketInsights).mockResolvedValue({data:[{id:'1',title:'real',category:'TREND',source:'https://example.org/evidence',opportunity:'evidence',impact:'HIGH',recommendedAction:'review',status:'DISCOVERED',createdAt:'2026-10-28'}],meta});
|
||||
render(<Market />);
|
||||
expect((await screen.findByRole('link', {name:'مشاهده منبع'})).getAttribute('href')).toBe('https://example.org/evidence');
|
||||
});
|
||||
@@ -1,4 +1,7 @@
|
||||
import { useEffect, useState } from 'react';
|
||||
import HermesPagination from '../components/HermesPagination';
|
||||
import type { PageMeta } from '../services/hermesApi';
|
||||
import HermesSource from '../components/HermesSource';
|
||||
import {
|
||||
Compass,
|
||||
RefreshCw,
|
||||
@@ -29,25 +32,28 @@ export default function MarketIntelligencePage() {
|
||||
const [error, setError] = useState(false);
|
||||
const [loading, setLoading] = useState(true);
|
||||
const [reload, setReload] = useState(0);
|
||||
const [page, setPage] = useState(1);
|
||||
const [meta, setMeta] = useState<PageMeta | null>(null);
|
||||
|
||||
useEffect(() => {
|
||||
const controller = new AbortController();
|
||||
setLoading(true);
|
||||
setError(false);
|
||||
setMeta(null);
|
||||
setInsights([]);
|
||||
hermesApi
|
||||
.getMarketInsights(controller.signal)
|
||||
.getMarketInsights({ page, limit: 10, category: category || undefined }, controller.signal)
|
||||
.then((data) => {
|
||||
if (!controller.signal.aborted) setInsights(data);
|
||||
if (!controller.signal.aborted) { setInsights(data.data); setMeta(data.meta); }
|
||||
})
|
||||
.catch(() => { if (!controller.signal.aborted) setError(true); })
|
||||
.finally(() => {
|
||||
if (!controller.signal.aborted) setLoading(false);
|
||||
});
|
||||
return () => controller.abort();
|
||||
}, [reload]);
|
||||
}, [reload, page, category]);
|
||||
|
||||
const filtered = category ? insights.filter((i) => i.category === category) : insights;
|
||||
const filtered = insights;
|
||||
|
||||
return (
|
||||
<div className="p-4 sm:p-6 lg:p-8 space-y-6 max-w-7xl mx-auto" dir="rtl">
|
||||
@@ -84,19 +90,19 @@ export default function MarketIntelligencePage() {
|
||||
{/* فیلتر دستهبندی */}
|
||||
<div className="flex flex-wrap gap-2">
|
||||
<button
|
||||
onClick={() => setCategory('')}
|
||||
onClick={() => { setCategory(''); setPage(1); }}
|
||||
className={`px-3 py-1.5 rounded-xl text-xs font-bold border transition-all cursor-pointer ${
|
||||
category === ''
|
||||
? 'bg-slate-900 text-white border-slate-900 shadow-xs'
|
||||
: 'bg-white text-slate-600 border-slate-200 hover:bg-slate-50'
|
||||
}`}
|
||||
>
|
||||
همه بینشها ({insights.length})
|
||||
همه بینشها
|
||||
</button>
|
||||
{Object.entries(categoryLabels).map(([k, v]) => (
|
||||
<button
|
||||
key={k}
|
||||
onClick={() => setCategory(k)}
|
||||
onClick={() => { setCategory(k); setPage(1); }}
|
||||
className={`px-3 py-1.5 rounded-xl text-xs font-bold border transition-all cursor-pointer ${
|
||||
category === k
|
||||
? 'bg-slate-900 text-white border-slate-900 shadow-xs'
|
||||
@@ -149,13 +155,14 @@ export default function MarketIntelligencePage() {
|
||||
</div>
|
||||
|
||||
<div className="pt-3 border-t border-slate-100 flex items-center justify-between text-[11px] text-slate-400">
|
||||
<span>منبع داده: {item.source}</span>
|
||||
<HermesSource source={item.source} />
|
||||
<span>ثبت: {date(item.createdAt)}</span>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
})}
|
||||
</div>
|
||||
<HermesPagination meta={meta} loading={loading} onPage={setPage} />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -1,4 +1,6 @@
|
||||
import { useEffect, useState } from 'react';
|
||||
import HermesPagination from '../components/HermesPagination';
|
||||
import type { PageMeta } from '../services/hermesApi';
|
||||
import {
|
||||
Calendar,
|
||||
CheckCircle2,
|
||||
@@ -17,25 +19,28 @@ export default function MonthlyRoadmapPage() {
|
||||
const [error, setError] = useState(false);
|
||||
const [loading, setLoading] = useState(true);
|
||||
const [reload, setReload] = useState(0);
|
||||
const [page, setPage] = useState(1);
|
||||
const [meta, setMeta] = useState<PageMeta | null>(null);
|
||||
|
||||
useEffect(() => {
|
||||
const controller = new AbortController();
|
||||
setLoading(true);
|
||||
setError(false);
|
||||
setMeta(null);
|
||||
setRoadmap([]);
|
||||
hermesApi
|
||||
.getMonthlyRoadmap(controller.signal)
|
||||
.getMonthlyRoadmap({ page, limit: 10 }, controller.signal)
|
||||
.then((data) => {
|
||||
if (!controller.signal.aborted) setRoadmap(data);
|
||||
if (!controller.signal.aborted) { setRoadmap(data.data); setMeta(data.meta); }
|
||||
})
|
||||
.catch(() => { if (!controller.signal.aborted) setError(true); })
|
||||
.finally(() => {
|
||||
if (!controller.signal.aborted) setLoading(false);
|
||||
});
|
||||
return () => controller.abort();
|
||||
}, [reload]);
|
||||
}, [reload, page]);
|
||||
|
||||
const activePlan = roadmap.find((item) => item.isActive);
|
||||
// Render every persisted cycle in the selected server page, not just the first.
|
||||
|
||||
return (
|
||||
<div className="p-4 sm:p-6 lg:p-8 space-y-6 max-w-7xl mx-auto" dir="rtl">
|
||||
@@ -69,13 +74,14 @@ export default function MonthlyRoadmapPage() {
|
||||
{error && <p role="alert">دادهها در دسترس نیست؛ دریافت از سرور ناموفق بود.</p>}
|
||||
{!loading && !error && roadmap.length === 0 && <p>هنوز دادهای ثبت نشده است.</p>}
|
||||
|
||||
{roadmap.map((activePlan) => <section key={activePlan.id} className="space-y-6">
|
||||
{/* بنر چرخه فعال */}
|
||||
{activePlan && (
|
||||
<div className="bg-gradient-to-l from-purple-900 to-indigo-900 text-white rounded-3xl p-6 sm:p-8 shadow-xl relative overflow-hidden">
|
||||
<div className="relative z-10 space-y-4 max-w-3xl">
|
||||
<div className="inline-flex items-center gap-2 px-3 py-1 rounded-full bg-white/10 backdrop-blur-md text-xs font-semibold text-purple-200 border border-white/15">
|
||||
<Sparkles className="w-3.5 h-3.5 text-amber-300" />
|
||||
<span>چرخه استراتژیک فعال: {activePlan.month}</span>
|
||||
<span>چرخه استراتژیک {activePlan.isActive ? 'فعال' : 'بایگانی'}: {activePlan.month}</span>
|
||||
</div>
|
||||
|
||||
<h2 className="text-2xl sm:text-3xl font-black tracking-tight">{activePlan.cycleName}</h2>
|
||||
@@ -100,7 +106,7 @@ export default function MonthlyRoadmapPage() {
|
||||
<FileText className="w-4 h-4" />
|
||||
</div>
|
||||
</div>
|
||||
<div className="text-3xl font-black text-slate-900">{activePlan.plannedArticlesCount} <span className="text-sm font-normal text-slate-500">مقاله</span></div>
|
||||
<div className="text-3xl font-black text-slate-900">{typeof activePlan.plannedArticlesCount === 'number' ? activePlan.plannedArticlesCount : 'ناموجود'} <span className="text-sm font-normal text-slate-500">مقاله</span></div>
|
||||
<p className="text-xs text-slate-500 leading-relaxed">
|
||||
هدف: روزانه یک مقاله جدید؛ بازنگری مقالات جایگزین این هدف نیست.
|
||||
</p>
|
||||
@@ -126,7 +132,7 @@ export default function MonthlyRoadmapPage() {
|
||||
<Package className="w-4 h-4" />
|
||||
</div>
|
||||
</div>
|
||||
<div className="text-3xl font-black text-slate-900">{activePlan.plannedCatalogEnrichments} <span className="text-sm font-normal text-slate-500">محصول / ماده</span></div>
|
||||
<div className="text-3xl font-black text-slate-900">{typeof activePlan.plannedCatalogEnrichments === 'number' ? activePlan.plannedCatalogEnrichments : 'ناموجود'} <span className="text-sm font-normal text-slate-500">محصول / ماده</span></div>
|
||||
<p className="text-xs text-slate-500 leading-relaxed">
|
||||
تکمیل ۵ تب مشخصات کالاها و لینک دوطرفه با دانشنامه ترکیبات کنینا.
|
||||
</p>
|
||||
@@ -157,6 +163,8 @@ export default function MonthlyRoadmapPage() {
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
</section>)}
|
||||
<HermesPagination meta={meta} loading={loading} onPage={setPage} />
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -4,11 +4,29 @@ import { hermesApi } from './hermesApi';
|
||||
vi.mock('./api', () => ({ default: { get: vi.fn(), post: vi.fn() } }));
|
||||
beforeEach(() => vi.resetAllMocks());
|
||||
describe('Hermes API honesty', () => {
|
||||
it('preserves pagination in market envelopes', async () => {
|
||||
const result = { data: [], meta: { total: 20, page: 2, limit: 10, totalPages: 2, hasNextPage: false, hasPrevPage: true } };
|
||||
vi.mocked(api.get).mockResolvedValue({ data: result });
|
||||
expect(await hermesApi.getMarketInsights({ page: 2, limit: 10 })).toEqual(result);
|
||||
});
|
||||
it('rejects malformed successful create responses', async () => {
|
||||
vi.mocked(api.post).mockResolvedValue({ data: { success: false } });
|
||||
await expect(hermesApi.createCeoTask({title:'test',description:'test',department:'CONTENT_SEO'})).rejects.toThrow();
|
||||
});
|
||||
it.each(['getTasks', 'getTaskById', 'getMarketInsights', 'getMonthlyRoadmap'] as const)('%s rejects unavailable service', async (method) => {
|
||||
vi.mocked(api.get).mockRejectedValue(new Error('unavailable'));
|
||||
const result = method === 'getTaskById' ? hermesApi.getTaskById('real-id') : hermesApi[method]();
|
||||
await expect(result).rejects.toThrow('unavailable');
|
||||
});
|
||||
it('supports service-unwrapped nested list envelopes', async () => {
|
||||
const result = {data:[],meta:{total:0,page:1,limit:10,totalPages:0,hasNextPage:false,hasPrevPage:false}};
|
||||
vi.mocked(api.get).mockResolvedValue({data:{data:result}});
|
||||
expect(await hermesApi.getMonthlyRoadmap()).toEqual(result);
|
||||
});
|
||||
it('rejects malformed lists rather than rendering measured zero', async () => {
|
||||
vi.mocked(api.get).mockResolvedValue({data:{data:[]}});
|
||||
await expect(hermesApi.getTasks()).rejects.toThrow('پاسخ صفحه');
|
||||
});
|
||||
it('never fabricates successful creation', async () => {
|
||||
vi.mocked(api.post).mockRejectedValue(new Error('not saved'));
|
||||
await expect(hermesApi.createCeoTask({ title: 'directive', description: 'acceptance', department: 'CONTENT_SEO' })).rejects.toThrow('not saved');
|
||||
|
||||
@@ -89,10 +89,26 @@ export interface MonthlyRoadmapItem {
|
||||
createdAt: string;
|
||||
}
|
||||
|
||||
export type PageMeta = TasksResponse['meta'];
|
||||
export interface PaginatedResponse<T> { data: T[]; meta: PageMeta }
|
||||
export interface ListParams { page?: number; limit?: number; category?: string }
|
||||
|
||||
function pageResult<T>(body: unknown): PaginatedResponse<T> {
|
||||
const outer = body as { data?: unknown; meta?: unknown } | null;
|
||||
const result = (outer?.meta ? outer : outer?.data) as PaginatedResponse<T> | undefined;
|
||||
if (!Array.isArray(result?.data) || !result?.meta ||
|
||||
!Number.isFinite(result.meta.total) || !Number.isFinite(result.meta.page) ||
|
||||
!Number.isFinite(result.meta.totalPages) || !Number.isFinite(result.meta.limit) ||
|
||||
typeof result.meta.hasNextPage !== 'boolean' || typeof result.meta.hasPrevPage !== 'boolean') {
|
||||
throw new Error('پاسخ صفحهبندی سرور معتبر نیست.');
|
||||
}
|
||||
return result;
|
||||
}
|
||||
|
||||
export const hermesApi = {
|
||||
getTasks: async (params: TaskFilterParams = {}, signal?: AbortSignal): Promise<TasksResponse> => {
|
||||
const response = await api.get('/admin/hermes/tasks', { params, signal });
|
||||
return response.data;
|
||||
return pageResult<CorporateTaskItem>(response.data);
|
||||
},
|
||||
getTaskById: async (id: string, signal?: AbortSignal): Promise<CorporateTaskItem> => {
|
||||
const response = await api.get(`/admin/hermes/tasks/${encodeURIComponent(id)}`, { signal });
|
||||
@@ -104,12 +120,12 @@ export const hermesApi = {
|
||||
if (!item?.id || !item?.taskCode) throw new Error('پاسخ ثبت تسک معتبر نیست؛ ثبت تأیید نشد.');
|
||||
return item;
|
||||
},
|
||||
getMarketInsights: async (signal?: AbortSignal): Promise<MarketInsightItem[]> => {
|
||||
const response = await api.get('/admin/hermes/market-insights', { signal });
|
||||
return response.data?.data ?? response.data;
|
||||
getMarketInsights: async (params: ListParams = {}, signal?: AbortSignal): Promise<PaginatedResponse<MarketInsightItem>> => {
|
||||
const response = await api.get('/admin/hermes/market-insights', { params, signal });
|
||||
return pageResult<MarketInsightItem>(response.data);
|
||||
},
|
||||
getMonthlyRoadmap: async (signal?: AbortSignal): Promise<MonthlyRoadmapItem[]> => {
|
||||
const response = await api.get('/admin/hermes/monthly-roadmap', { signal });
|
||||
return response.data?.data ?? response.data;
|
||||
getMonthlyRoadmap: async (params: ListParams = {}, signal?: AbortSignal): Promise<PaginatedResponse<MonthlyRoadmapItem>> => {
|
||||
const response = await api.get('/admin/hermes/monthly-roadmap', { params, signal });
|
||||
return pageResult<MonthlyRoadmapItem>(response.data);
|
||||
},
|
||||
};
|
||||
@@ -0,0 +1,5 @@
|
||||
# Local verification
|
||||
Urgent commit 38efc97: six API tests RED (synthetic reads/create resolved and detail envelope wrong), then nine targeted tests GREEN; admin Vite build passed.
|
||||
Integrated RED: four failures (server meta discarded; page crashes on envelope; no source link); detail test RED confirmed no detail request. Implemented pageResult envelope validation, server category/page/limit and metadata navigation, all roadmap cycles displayed, HTTP(S) source links, authenticated existing Axios create and independent detail fetch, unavailable/empty/loading separation.
|
||||
Full admin suite before final extra edge-case tests: 56 files / 358 tests passed, typecheck passed, Vite build passed (2444 modules, 4.76s). Logs outside Git at /opt/data/cache/scratch/corporate-ui-admin-{tests,build}.log. Final full rerun: 57 files / 364 tests passed; typecheck and git diff --check passed. Final log /opt/data/cache/scratch/corporate-ui-admin-tests-final.log. Tests use mocked API contracts, not live backend or database; parent owns integrated Stage acceptance. No push/deployment/backend/runtime/cron changes. Shared dependency symlink is ignored. Graph cache query stamp is excluded from commits.
|
||||
Limitations: roadmap persisted type has no source URL; no synthetic provenance field introduced. Market source links only when existing source contains HTTP(S). No clinical content, budget, quota or worker behavior changed. Daily one-new-article goal is explicit and refresh work is separately needs-based. No approvals modules.
|
||||
@@ -1,5 +1,5 @@
|
||||
# Tasks
|
||||
1. [ ] Write and run RED regression tests for failed API reads/create and page unavailable states.
|
||||
2. [ ] Remove synthetic fallback/summaries, add explicit errors; run tests and build; urgent commit.
|
||||
3. [ ] Implement paginated market/roadmap with API meta and source links; detail API read.
|
||||
4. [ ] Run targeted/full admin tests and build; record exact results and local-only commits.
|
||||
1. [x] Write and run RED regression tests for failed API reads/create and page unavailable states.
|
||||
2. [x] Remove synthetic fallback/summaries, add explicit errors; run tests and build; urgent commit.
|
||||
3. [x] Implement paginated market/roadmap with API meta and source links; detail API read.
|
||||
4. [x] Run targeted/full admin tests and build; record exact results and local-only commits.
|
||||
Reference in new issue
Block a user