Close anonymous write access to the public API and repair the broken test suite
Deploy Backend / deploy (push) Has been cancelled
Deploy Backend / deploy (push) Has been cancelled
Every mutating endpoint was reachable without authentication, so any visitor
could create, edit or delete posts, categories, tags, projects and about-me
records on the live site.
Security
- Split routes into an anonymous read-only group and a write group gated by
`auth:sanctum` + a new `admin` middleware.
- Add `is_admin` to users; Sanctum token support on the User model.
- Add AuthController (login / me / logout). The Sanctum token is delivered in
an httpOnly cookie and never returned in the JSON body, because the admin
panel reaches the API through a Next.js server-side proxy that breaks
Sanctum's first-party domain detection.
- AuthenticateAdminPanelSession promotes that cookie to a bearer header so
Sanctum's normal validation, expiry and revocation still apply.
- Remove the unauthenticated `/user/{id}` route, which exposed user emails.
- Non-admin accounts are refused at login and the failure shape is identical
to a bad password, so the endpoint cannot enumerate accounts.
- Fix `Route [login] not defined`: a non-JSON unauthenticated request resolved
a route that does not exist in this API-only app and returned 500.
- Reject invalid list query parameters with 422 instead of 500, and cap
per_page at 50 (`?per_page=100000` previously dumped whole tables).
Correctness
- Make the translation migration portable. It used MySQL-only JSON_OBJECTAGG,
which aborted all 29 tests during migration; the data collapse now runs in
PHP so it works on MySQL, MariaDB and SQLite.
- Add HasJsonTranslations trait providing the missing setTranslation(), which
made project create/update return 500, and replace five copy-pasted
getTranslation()/hasTranslation() bodies.
- Make posts.excerpt nullable to match StorePostRequest; omitting an excerpt
was a guaranteed SQL integrity error.
- Route the AboutMeController CRUD methods that existed but were never
registered.
- CategoryTest omitted a required description; fixed the test, the existing
schema and validation already agreed.
Tests: 83 passing / 126 assertions (was 29 failing / 0 assertions)
This commit is contained in:
1 parent
35686d82c3
commit
d2f6bd4d7d
29 files changed
+1002
-188
No files matched your search
@@ -0,0 +1,47 @@
|
||||
<?php
|
||||
|
||||
namespace App\Http\Controllers\Concerns;
|
||||
|
||||
use Illuminate\Http\Request;
|
||||
|
||||
trait ValidatesListQuery
|
||||
{
|
||||
/**
|
||||
* Validate the shared list-endpoint query parameters.
|
||||
*
|
||||
* `per_page` was previously read straight from the request, so
|
||||
* `?per_page=100000` returned the entire table in one response. Sort
|
||||
* columns and directions were also passed through unchecked, and
|
||||
* `?sort_direction=foo` made the query builder throw, turning a bad
|
||||
* query string into an HTTP 500.
|
||||
*
|
||||
* Invalid values are now rejected with a 422 and the sort field is
|
||||
* restricted to a per-endpoint allow-list.
|
||||
*
|
||||
* @param array<int, string> $sortable
|
||||
* @return array{per_page: int, page: int, sort: string, direction: string}
|
||||
*/
|
||||
protected function listQuery(
|
||||
Request $request,
|
||||
array $sortable,
|
||||
string $sortParam = 'sort_by',
|
||||
string $defaultSort = 'created_at',
|
||||
string $defaultDirection = 'desc',
|
||||
int $defaultPerPage = 10,
|
||||
int $maxPerPage = 50
|
||||
): array {
|
||||
$validated = $request->validate([
|
||||
'per_page' => ['nullable', 'integer', 'min:1', 'max:'.$maxPerPage],
|
||||
'page' => ['nullable', 'integer', 'min:1'],
|
||||
$sortParam => ['nullable', 'string', 'in:'.implode(',', $sortable)],
|
||||
'sort_direction' => ['nullable', 'string', 'in:asc,desc'],
|
||||
]);
|
||||
|
||||
return [
|
||||
'per_page' => (int) ($validated['per_page'] ?? $defaultPerPage),
|
||||
'page' => (int) ($validated['page'] ?? 1),
|
||||
'sort' => $validated[$sortParam] ?? $defaultSort,
|
||||
'direction' => $validated['sort_direction'] ?? $defaultDirection,
|
||||
];
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user