Close anonymous write access to the public API and repair the broken test suite
Deploy Backend / deploy (push) Has been cancelled
Deploy Backend / deploy (push) Has been cancelled
Every mutating endpoint was reachable without authentication, so any visitor
could create, edit or delete posts, categories, tags, projects and about-me
records on the live site.
Security
- Split routes into an anonymous read-only group and a write group gated by
`auth:sanctum` + a new `admin` middleware.
- Add `is_admin` to users; Sanctum token support on the User model.
- Add AuthController (login / me / logout). The Sanctum token is delivered in
an httpOnly cookie and never returned in the JSON body, because the admin
panel reaches the API through a Next.js server-side proxy that breaks
Sanctum's first-party domain detection.
- AuthenticateAdminPanelSession promotes that cookie to a bearer header so
Sanctum's normal validation, expiry and revocation still apply.
- Remove the unauthenticated `/user/{id}` route, which exposed user emails.
- Non-admin accounts are refused at login and the failure shape is identical
to a bad password, so the endpoint cannot enumerate accounts.
- Fix `Route [login] not defined`: a non-JSON unauthenticated request resolved
a route that does not exist in this API-only app and returned 500.
- Reject invalid list query parameters with 422 instead of 500, and cap
per_page at 50 (`?per_page=100000` previously dumped whole tables).
Correctness
- Make the translation migration portable. It used MySQL-only JSON_OBJECTAGG,
which aborted all 29 tests during migration; the data collapse now runs in
PHP so it works on MySQL, MariaDB and SQLite.
- Add HasJsonTranslations trait providing the missing setTranslation(), which
made project create/update return 500, and replace five copy-pasted
getTranslation()/hasTranslation() bodies.
- Make posts.excerpt nullable to match StorePostRequest; omitting an excerpt
was a guaranteed SQL integrity error.
- Route the AboutMeController CRUD methods that existed but were never
registered.
- CategoryTest omitted a required description; fixed the test, the existing
schema and validation already agreed.
Tests: 83 passing / 126 assertions (was 29 failing / 0 assertions)
This commit is contained in:
1 parent
35686d82c3
commit
d2f6bd4d7d
29 files changed
+1002
-188
No files matched your search
@@ -0,0 +1,122 @@
|
||||
<?php
|
||||
|
||||
namespace App\Http\Controllers\Api;
|
||||
|
||||
use App\Http\Controllers\Controller;
|
||||
use App\Http\Resources\UserResource;
|
||||
use App\Models\User;
|
||||
use Illuminate\Http\JsonResponse;
|
||||
use Illuminate\Http\Request;
|
||||
use Illuminate\Support\Facades\Auth;
|
||||
use Illuminate\Validation\ValidationException;
|
||||
use Symfony\Component\HttpFoundation\Cookie;
|
||||
|
||||
class AuthController extends Controller
|
||||
{
|
||||
/**
|
||||
* Name given to the personal access token backing the admin panel
|
||||
* session, so it can be revoked from `php artisan sanctum` output.
|
||||
*/
|
||||
private const TOKEN_NAME = 'admin-panel';
|
||||
|
||||
/**
|
||||
* Cookie carrying the Sanctum token. It is httpOnly so no client-side
|
||||
* JavaScript can read it, and the value is never echoed in the JSON body.
|
||||
*
|
||||
* The admin panel lives behind a Next.js server-side proxy, which is why
|
||||
* the token is carried this way rather than relying on Sanctum's
|
||||
* first-party (stateful) domain detection: a proxied request does not
|
||||
* always carry an Origin/Referer the backend recognises as stateful.
|
||||
*/
|
||||
public const SESSION_COOKIE = 'parsaaghayi_admin_session';
|
||||
|
||||
public function login(Request $request): JsonResponse
|
||||
{
|
||||
$credentials = $request->validate([
|
||||
'email' => ['required', 'string', 'email'],
|
||||
'password' => ['required', 'string'],
|
||||
'remember' => ['sometimes', 'boolean'],
|
||||
]);
|
||||
|
||||
if (! Auth::attempt(['email' => $credentials['email'], 'password' => $credentials['password']], (bool) ($credentials['remember'] ?? false))) {
|
||||
throw ValidationException::withMessages([
|
||||
'email' => __('auth.failed'),
|
||||
]);
|
||||
}
|
||||
|
||||
$user = $request->user();
|
||||
|
||||
// A valid but non-admin account must not be able to hold a session,
|
||||
// and must not be distinguishable from a bad password.
|
||||
if (! $user->isAdmin()) {
|
||||
Auth::guard('web')->logout();
|
||||
|
||||
throw ValidationException::withMessages([
|
||||
'email' => __('auth.failed'),
|
||||
]);
|
||||
}
|
||||
|
||||
// One live session at a time for the admin panel.
|
||||
$user->tokens()->where('name', self::TOKEN_NAME)->delete();
|
||||
|
||||
$token = $user->createToken(self::TOKEN_NAME)->plainTextToken;
|
||||
|
||||
return response()->json([
|
||||
'user' => new UserResource($user),
|
||||
])->cookie($this->makeCookie($token, (int) ($credentials['remember'] ?? false) ? 1209600 : null));
|
||||
}
|
||||
|
||||
public function me(Request $request): JsonResponse
|
||||
{
|
||||
$user = $request->user();
|
||||
|
||||
if (! $user->isAdmin()) {
|
||||
return response()->json(['message' => 'This action is unauthorized.'], 403);
|
||||
}
|
||||
|
||||
return response()->json([
|
||||
'user' => new UserResource($user),
|
||||
]);
|
||||
}
|
||||
|
||||
public function logout(Request $request): JsonResponse
|
||||
{
|
||||
$user = $request->user();
|
||||
|
||||
if ($user) {
|
||||
$user->tokens()->where('name', self::TOKEN_NAME)->delete();
|
||||
|
||||
Auth::guard('web')->logout();
|
||||
}
|
||||
|
||||
return response()->json(['message' => 'Logged out.'])
|
||||
->withoutCookie(self::SESSION_COOKIE);
|
||||
}
|
||||
|
||||
/**
|
||||
* @return Cookie
|
||||
*/
|
||||
private function makeCookie(string $token, ?int $minutes)
|
||||
{
|
||||
return cookie(
|
||||
name: self::SESSION_COOKIE,
|
||||
value: $token,
|
||||
minutes: $minutes,
|
||||
path: '/',
|
||||
domain: config('session.domain'),
|
||||
secure: (bool) config('session.secure', true),
|
||||
httpOnly: true,
|
||||
sameSite: 'lax',
|
||||
);
|
||||
}
|
||||
|
||||
/**
|
||||
* Bootstrap helper: promote an existing account to admin from the CLI.
|
||||
*/
|
||||
public static function grantAdmin(string $email): ?User
|
||||
{
|
||||
$user = User::where('email', $email)->first();
|
||||
|
||||
return $user?->forceFill(['is_admin' => true])->save() ? $user : null;
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user