import { PrepareWorkflowService } from './prepare-workflow.service'; describe('atomic approval queue contract', () => { let t:any, tx:any, service:PrepareWorkflowService; const actor={id:'reviewer',role:'SUPER_ADMIN'}; const command={decision:'APPROVED',expectedVersion:2,idempotencyKey:'approve'}; beforeEach(()=>{ t={id:'t',state:'GATE1_PENDING',version:2,operationMode:'PREPARE',metadata:{workflowScope:'STAGE_PREPARE',createdBy:'pmo'}}; tx={$queryRaw:jest.fn().mockResolvedValue([]),orchestrationTask:{findUnique:jest.fn(async()=>t),update:jest.fn(async({data}:any)=>(t={...t,...data,version:t.version+1}))},orchestrationEvent:{findUnique:jest.fn(),create:jest.fn()},orchestrationApprovalDecision:{create:jest.fn()},prepareWorkflowOutbox:{create:jest.fn()}}; service=new PrepareWorkflowService({$transaction:async(fn:any)=>fn(tx)},{workerIds:['pmo'],stageCiIds:[]}); }); it('approval with no date enters READY and creates exactly one outbox atomically',async()=>{ await expect(service.decide('t',1,command,actor)).resolves.toMatchObject({state:'READY',version:3}); expect(tx.prepareWorkflowOutbox.create).toHaveBeenCalledTimes(1); expect(tx.orchestrationApprovalDecision.create).toHaveBeenCalledWith({data:expect.objectContaining({actorId:'reviewer',expiresAt:expect.any(Date),notes:expect.any(String)})}); tx.orchestrationEvent.findUnique.mockResolvedValue(tx.orchestrationEvent.create.mock.calls[0][0].data); await service.decide('t',1,command,actor); expect(tx.prepareWorkflowOutbox.create).toHaveBeenCalledTimes(1); expect(tx.orchestrationApprovalDecision.create).toHaveBeenCalledTimes(1); await expect(service.decide('t',1,{...command,notes:'changed'},actor)).rejects.toMatchObject({status:409}); }); it('future schedule is durable and server expiry extends beyond it',async()=>{ const notBefore=new Date(Date.now()+7*86400000).toISOString(); await service.decide('t',1,{...command,notBefore},actor); const data=tx.prepareWorkflowOutbox.create.mock.calls[0][0].data; expect(data.notBefore).toEqual(new Date(notBefore)); expect(tx.orchestrationApprovalDecision.create.mock.calls[0][0].data.expiresAt.getTime()).toBeGreaterThan(Date.parse(notBefore)); }); it('rejected decision never queues',async()=>{ await expect(service.decide('t',1,{...command,decision:'REJECTED'},actor)).resolves.toMatchObject({state:'REJECTED'}); expect(tx.prepareWorkflowOutbox.create).not.toHaveBeenCalled(); }); it.each([new Date(0).toISOString(),new Date(Date.now()+31*86400000).toISOString(),'bad'])('denies invalid schedule %s',async notBefore=>{ await expect(service.decide('t',1,{...command,notBefore},actor)).rejects.toMatchObject({status:400}); expect(tx.orchestrationApprovalDecision.create).not.toHaveBeenCalled(); }); it('legacy explicit expiry remains an expiry, never a schedule',async()=>{ const expiresAt=new Date(Date.now()+60000).toISOString(); await service.decide('t',1,{...command,expiresAt},actor); expect(tx.orchestrationApprovalDecision.create.mock.calls[0][0].data.expiresAt).toEqual(new Date(expiresAt)); expect(tx.prepareWorkflowOutbox.create.mock.calls[0][0].data.notBefore).toBeNull(); }); it('expired approval is denied with no writes',async()=>{ await expect(service.decide('t',1,{...command,expiresAt:new Date(0).toISOString()},actor)).rejects.toMatchObject({status:400}); expect(tx.prepareWorkflowOutbox.create).not.toHaveBeenCalled(); }); });