fix(security): resolve all critical, high, and medium security vulnerabilities
Deploy Canina / deploy (push) Waiting to run
E2E Playwright Tests / Run Full E2E & Security Suites (push) Failing after 11s

This commit is contained in:
parsa committed 2026-09-23 22:05:12 +03:30
1 parent da26dd1c8d
commit dc88677169
33 files changed
+438 -85

No files matched your search

+18 -2
View File
@@ -8,6 +8,7 @@ import {
Param,
Query,
UseGuards,
BadRequestException,
} from '@nestjs/common';
import { AdminService, CouponInput } from './admin.service';
import { ProductDto } from './dto/product.dto';
@@ -28,9 +29,13 @@ import {
import { CreateUserDto, UpdateUserDto } from './dto/user.dto';
import { SettingsService } from '../settings/settings.service';
import { RolesGuard } from '../common/guards/roles.guard';
import { Roles } from '../common/decorators/roles.decorator';
@ApiTags('Admin - مدیریت سیستم')
@ApiBearerAuth()
@UseGuards(JwtAuthGuard)
@UseGuards(JwtAuthGuard, RolesGuard)
@Roles('Admin', 'SUPER_ADMIN')
@Controller('admin')
export class AdminController {
constructor(
@@ -109,9 +114,20 @@ export class AdminController {
@Body('type') type: 'deposit' | 'withdrawal' | 'refund',
@Body('description') description?: string,
) {
const numAmount = Number(amount);
if (!numAmount || isNaN(numAmount) || numAmount <= 0) {
throw new BadRequestException('مبلغ باید یک عدد مثبت باشد');
}
if (numAmount > 100_000_000_000) {
throw new BadRequestException('مبلغ بیش از حد مجاز است');
}
if (!['deposit', 'withdrawal', 'refund'].includes(type)) {
throw new BadRequestException('نوع تراکنش معتبر نیست');
}
const result = await this.adminService.adjustUserWallet(
id,
Number(amount),
numAmount,
type,
description,
);
+1 -1
View File
@@ -45,6 +45,6 @@ import { SettingsModule } from '../settings/settings.module';
SslService,
ApiKeysService,
],
exports: [ApiKeysService],
exports: [ApiKeysService, MediaService],
})
export class AdminModule {}
+23 -1
View File
@@ -61,6 +61,16 @@ export class CouponInput {
targets?: CouponTargetInput[];
}
const ALLOWED_USER_ROLES = [
'User_PetOwner',
'User_Vet',
'User_Clinic',
'User_PetShop',
'Customer',
'Admin',
'SUPER_ADMIN',
];
@Injectable()
export class AdminService {
constructor(
@@ -244,6 +254,10 @@ export class AdminService {
? await bcrypt.hash(passwordToHash, 10)
: '';
if (dto.role && !ALLOWED_USER_ROLES.includes(dto.role)) {
throw new BadRequestException('نقش کاربری مشخص شده نامعتبر است');
}
return this.prisma.user.create({
data: {
firstName: dto.firstName.trim(),
@@ -307,7 +321,12 @@ export class AdminService {
if (normalizedMobile !== undefined) updateData.mobile = normalizedMobile;
if (normalizedEmail !== undefined)
updateData.email = normalizedEmail || null;
if (dto.role !== undefined) updateData.role = dto.role;
if (dto.role !== undefined) {
if (!ALLOWED_USER_ROLES.includes(dto.role)) {
throw new BadRequestException('نقش کاربری مشخص شده نامعتبر است');
}
updateData.role = dto.role;
}
if (dto.walletBalance !== undefined) {
updateData.walletBalance = new Prisma.Decimal(dto.walletBalance);
}
@@ -322,6 +341,9 @@ export class AdminService {
}
async updateUserRole(id: string, role: string) {
if (!ALLOWED_USER_ROLES.includes(role)) {
throw new BadRequestException('نقش کاربری مشخص شده نامعتبر است');
}
return this.prisma.user.update({
where: { id },
data: { role },
+5 -1
View File
@@ -19,9 +19,13 @@ import {
ApiResponse,
} from '@nestjs/swagger';
import { RolesGuard } from '../common/guards/roles.guard';
import { Roles } from '../common/decorators/roles.decorator';
@ApiTags('Admin - مدیریت کلیدهای دسترسی (API Keys)')
@ApiBearerAuth()
@UseGuards(JwtAuthGuard)
@UseGuards(JwtAuthGuard, RolesGuard)
@Roles('Admin', 'SUPER_ADMIN')
@Controller('admin/api-keys')
export class ApiKeysController {
constructor(private readonly apiKeysService: ApiKeysService) {}
+5 -2
View File
@@ -150,12 +150,15 @@ export class ApiKeysService {
})
.catch(() => {});
const scopes = key.scopes.split(',').map((s) => s.trim().toLowerCase());
const hasAdminScope = scopes.includes('*') || scopes.includes('admin') || scopes.includes('all');
return {
id: key.id,
name: key.name,
role: 'ADMIN', // Grants admin level access for n8n automation
role: hasAdminScope ? 'Admin' : 'USER',
email: 'apikey-system@canina.ir',
scopes: key.scopes.split(',').map((s) => s.trim()),
scopes,
isApiKey: true,
};
}
+5 -1
View File
@@ -22,9 +22,13 @@ import {
} from '@nestjs/swagger';
import { PaginationDto } from '../common/dto/pagination.dto';
import { RolesGuard } from '../common/guards/roles.guard';
import { Roles } from '../common/decorators/roles.decorator';
@ApiTags('Admin - مدیریت مقالات (بلاگ)')
@ApiBearerAuth()
@UseGuards(JwtAuthGuard)
@UseGuards(JwtAuthGuard, RolesGuard)
@Roles('Admin', 'SUPER_ADMIN')
@Controller('admin/blogs')
export class BlogsController {
constructor(private readonly blogsService: BlogsService) {}
+5 -1
View File
@@ -21,9 +21,13 @@ import {
import { PaginationDto } from '../common/dto/pagination.dto';
import { RolesGuard } from '../common/guards/roles.guard';
import { Roles } from '../common/decorators/roles.decorator';
@ApiTags('Admin - مدیریت دسته‌بندی‌ها')
@ApiBearerAuth()
@UseGuards(JwtAuthGuard)
@UseGuards(JwtAuthGuard, RolesGuard)
@Roles('Admin', 'SUPER_ADMIN')
@Controller('admin/categories')
export class CategoriesController {
constructor(private readonly categoriesService: CategoriesService) {}
+31 -6
View File
@@ -14,15 +14,26 @@ import {
import { FileInterceptor } from '@nestjs/platform-express';
import { MediaService } from './media.service';
import { JwtAuthGuard } from '../auth/jwt-auth.guard';
import { RolesGuard } from '../common/guards/roles.guard';
import { Roles } from '../common/decorators/roles.decorator';
import { ApiTags, ApiBearerAuth, ApiOperation } from '@nestjs/swagger';
const ALLOWED_MIME_TYPES = [
'image/jpeg',
'image/png',
'image/webp',
'image/gif',
'application/pdf',
];
@ApiTags('Admin - مدیریت رسانه (تصاویر)')
@ApiBearerAuth()
@UseGuards(JwtAuthGuard, RolesGuard)
@Roles('Admin', 'SUPER_ADMIN')
@Controller('admin/media')
export class MediaController {
constructor(private readonly mediaService: MediaService) {}
@UseGuards(JwtAuthGuard)
@Get()
@ApiOperation({ summary: 'لیست فایل‌های رسانه' })
async getAllMedia() {
@@ -31,15 +42,31 @@ export class MediaController {
}
@Post('upload')
@ApiOperation({ summary: 'آپلود فایل جدید (عمومی/ادمین)' })
@UseInterceptors(FileInterceptor('file'))
@ApiOperation({ summary: 'آپلود فایل جدید توسط ادمین' })
@UseInterceptors(
FileInterceptor('file', {
limits: {
fileSize: 10 * 1024 * 1024, // 10MB limit
},
fileFilter: (_req, file, callback) => {
if (!ALLOWED_MIME_TYPES.includes(file.mimetype)) {
return callback(
new BadRequestException(
'فرمت فایل مجاز نیست. تنها فرمت‌های تصویری و PDF پشتیبانی می‌شوند.',
),
false,
);
}
callback(null, true);
},
}),
)
async uploadFile(@UploadedFile() file: Express.Multer.File) {
if (!file) throw new BadRequestException('File is missing');
const data = await this.mediaService.uploadFile(file);
return { success: true, data };
}
@UseGuards(JwtAuthGuard)
@Delete('bulk')
@ApiOperation({ summary: 'حذف دسته‌جمعی فایل‌ها' })
async deleteManyMedia(@Body('ids') ids: string[]) {
@@ -50,7 +77,6 @@ export class MediaController {
return { success: true, data };
}
@UseGuards(JwtAuthGuard)
@Delete(':id')
@ApiOperation({ summary: 'حذف فایل' })
async deleteMedia(@Param('id') id: string) {
@@ -58,7 +84,6 @@ export class MediaController {
return { success: true, data };
}
@UseGuards(JwtAuthGuard)
@Put(':id')
@ApiOperation({
summary: 'ویرایش متادیتای سئوی فایل (Alt, Title, Description, Caption)',
+5 -1
View File
@@ -17,9 +17,13 @@ import {
import { PaginationDto } from '../common/dto/pagination.dto';
import { RolesGuard } from '../common/guards/roles.guard';
import { Roles } from '../common/decorators/roles.decorator';
@ApiTags('Admin - مدیریت حیوانات خانگی')
@ApiBearerAuth()
@UseGuards(JwtAuthGuard)
@UseGuards(JwtAuthGuard, RolesGuard)
@Roles('Admin', 'SUPER_ADMIN')
@Controller('admin/pets')
export class PetsController {
constructor(private readonly petsService: PetsService) {}
+5 -1
View File
@@ -8,13 +8,17 @@ import {
ApiQuery,
} from '@nestjs/swagger';
import { RolesGuard } from '../common/guards/roles.guard';
import { Roles } from '../common/decorators/roles.decorator';
@ApiTags('Admin - گزارشات')
@ApiBearerAuth()
@UseGuards(JwtAuthGuard, RolesGuard)
@Roles('Admin', 'SUPER_ADMIN')
@Controller('admin/reports')
export class ReportsController {
constructor(private readonly reportsService: ReportsService) {}
@UseGuards(JwtAuthGuard)
@Get()
@ApiOperation({
summary: 'دریافت گزارشات داشبورد با قابلیت فیلتر زمانی و نوع کاربر',
+5 -1
View File
@@ -21,9 +21,13 @@ import {
import { PaginationDto } from '../common/dto/pagination.dto';
import { RolesGuard } from '../common/guards/roles.guard';
import { Roles } from '../common/decorators/roles.decorator';
@ApiTags('Admin - مدیریت دانشنامه (اصطلاحات علمی)')
@ApiBearerAuth()
@UseGuards(JwtAuthGuard)
@UseGuards(JwtAuthGuard, RolesGuard)
@Roles('Admin', 'SUPER_ADMIN')
@Controller('admin/wiki')
export class WikiController {
constructor(private readonly wikiService: WikiService) {}