From aacb91ac70d72ce4d70cd04b9638cd37f0f13431 Mon Sep 17 00:00:00 2001 From: devops Date: Sun, 18 Oct 2026 15:47:12 +0000 Subject: [PATCH] fix(security): sanitize and block payment tokens and secrets in public ui-texts endpoint [FE-004] --- backend/src/settings/settings.service.spec.ts | 24 +++++++++++++++++- backend/src/settings/settings.service.ts | 25 ++++++++++++++++--- 2 files changed, 44 insertions(+), 5 deletions(-) diff --git a/backend/src/settings/settings.service.spec.ts b/backend/src/settings/settings.service.spec.ts index 24e7b9c7..b484ad1f 100644 --- a/backend/src/settings/settings.service.spec.ts +++ b/backend/src/settings/settings.service.spec.ts @@ -94,4 +94,26 @@ describe("SettingsService", () => { }); expect(result.key).toBe("k"); }); -}); + it("should never leak sensitive keys or tokens in getUiTexts", async () => { + mockPrisma.uiText.findMany.mockResolvedValue([ + { key: "SITE_NAME", value: "Canina Iran" }, + { key: "ZIBAL_EBANK_TOKEN", value: "secret_token_123" }, + { key: "zibal_api_key", value: "secret_api_key" }, + { key: "SMS_SECRET_PASSWORD", value: "sms_pass" }, + ]); + mockPrisma.setting.findMany.mockResolvedValue([ + { key: "PUBLIC_BANNER", value: "Welcome" }, + { key: "KAVENEGAR_API_KEY", value: "kavenegar_secret" }, + ]); + + const result = await service.getUiTexts(); + const returnedKeys = result.map((r) => r.key); + + expect(returnedKeys).toContain("SITE_NAME"); + expect(returnedKeys).toContain("PUBLIC_BANNER"); + expect(returnedKeys).not.toContain("ZIBAL_EBANK_TOKEN"); + expect(returnedKeys).not.toContain("zibal_api_key"); + expect(returnedKeys).not.toContain("SMS_SECRET_PASSWORD"); + expect(returnedKeys).not.toContain("KAVENEGAR_API_KEY"); + }); +}); \ No newline at end of file diff --git a/backend/src/settings/settings.service.ts b/backend/src/settings/settings.service.ts index df63c507..865581e9 100644 --- a/backend/src/settings/settings.service.ts +++ b/backend/src/settings/settings.service.ts @@ -269,10 +269,27 @@ export class SettingsService implements OnModuleInit { mergedMap.set("b2b_enabled", val); } - return Array.from(mergedMap.entries()).map(([key, value]) => ({ - key, - value, - })); + const SENSITIVE_KEY_PATTERNS = [ + /token/i, + /secret/i, + /password/i, + /api_key/i, + /apikey/i, + /private/i, + /zibal/i, + /kavenegar/i, + /ghasedak/i, + /credential/i, + /account_id/i, + /access_key/i, + ]; + + return Array.from(mergedMap.entries()) + .filter(([key]) => !SENSITIVE_KEY_PATTERNS.some((pattern) => pattern.test(key))) + .map(([key, value]) => ({ + key, + value, + })); } async updateUiText(key: string, value: string) {