feat(phase2): implement database optimization and RBAC enforcement
Deploy Canina / deploy (push) Failing after 28s
Deploy Canina / deploy (push) Failing after 28s
- TASK-FIN-001: Eliminate N+1 query loop in OrdersService.create with batched findMany query.
- Perform monetary calculations strictly using Prisma.Decimal methods (.add(), .mul(), .sub()).
- Add validation for duplicate product IDs and invalid quantities in order items.
- Implement global DecimalInterceptor registered in main.ts to serialize Prisma.Decimal values into exact string representations in API responses.
- TASK-SEC-003: Create roles.decorator.ts and roles.guard.ts in common directory with backward-compatible re-exports in auth directory.
- Enforce RBAC on SettingsController with @UseGuards(JwtAuthGuard, RolesGuard) and @Roles('Admin').
- Add unit specs for DecimalInterceptor, RolesGuard, SettingsController, and OrdersService Decimal batch operations.
This commit is contained in:
1 parent
a64291a19a
commit
809c69f923
13 files changed
+403
-128
No files matched your search
@@ -1,7 +1,9 @@
|
||||
import { Test, TestingModule } from '@nestjs/testing';
|
||||
import { OrdersService } from './orders.service';
|
||||
import { PrismaService } from '../prisma/prisma.service';
|
||||
import { SmsService } from '../common/services/sms.service';
|
||||
import { NotFoundException, BadRequestException } from '@nestjs/common';
|
||||
import { Prisma } from '@prisma/client';
|
||||
|
||||
describe('OrdersService', () => {
|
||||
let service: OrdersService;
|
||||
@@ -10,6 +12,7 @@ describe('OrdersService', () => {
|
||||
const mockPrisma = {
|
||||
product: {
|
||||
findUnique: jest.fn(),
|
||||
findMany: jest.fn(),
|
||||
},
|
||||
order: {
|
||||
create: jest.fn(),
|
||||
@@ -17,6 +20,17 @@ describe('OrdersService', () => {
|
||||
findFirst: jest.fn(),
|
||||
count: jest.fn(),
|
||||
},
|
||||
user: {
|
||||
findUnique: jest.fn(),
|
||||
update: jest.fn(),
|
||||
},
|
||||
walletTransaction: {
|
||||
create: jest.fn(),
|
||||
},
|
||||
};
|
||||
|
||||
const mockSmsService = {
|
||||
sendOrderConfirmation: jest.fn().mockResolvedValue(true),
|
||||
};
|
||||
|
||||
beforeEach(async () => {
|
||||
@@ -24,6 +38,7 @@ describe('OrdersService', () => {
|
||||
providers: [
|
||||
OrdersService,
|
||||
{ provide: PrismaService, useValue: mockPrisma },
|
||||
{ provide: SmsService, useValue: mockSmsService },
|
||||
],
|
||||
}).compile();
|
||||
|
||||
@@ -40,14 +55,6 @@ describe('OrdersService', () => {
|
||||
});
|
||||
|
||||
describe('create', () => {
|
||||
it('should throw NotFoundException if product does not exist', async () => {
|
||||
mockPrisma.product.findUnique.mockResolvedValue(null);
|
||||
const dto = { items: [{ productId: 'invalid-prod', quantity: 2 }] };
|
||||
await expect(service.create('user-id', dto)).rejects.toThrow(
|
||||
NotFoundException,
|
||||
);
|
||||
});
|
||||
|
||||
it('should throw BadRequestException if items are empty', async () => {
|
||||
const dto = { items: [] };
|
||||
await expect(service.create('user-id', dto)).rejects.toThrow(
|
||||
@@ -55,35 +62,68 @@ describe('OrdersService', () => {
|
||||
);
|
||||
});
|
||||
|
||||
it('should successfully create order and sum amounts', async () => {
|
||||
const prod = { id: 'prod-1', priceValue: 1000 };
|
||||
mockPrisma.product.findUnique.mockResolvedValue(prod);
|
||||
it('should throw BadRequestException for duplicate product IDs in order items', async () => {
|
||||
const dto = {
|
||||
items: [
|
||||
{ productId: 'prod-1', quantity: 1 },
|
||||
{ productId: 'prod-1', quantity: 2 },
|
||||
],
|
||||
};
|
||||
await expect(service.create('user-id', dto)).rejects.toThrow(
|
||||
BadRequestException,
|
||||
);
|
||||
});
|
||||
|
||||
it('should throw BadRequestException for non-positive or non-integer quantities', async () => {
|
||||
const dtoZero = { items: [{ productId: 'prod-1', quantity: 0 }] };
|
||||
await expect(service.create('user-id', dtoZero)).rejects.toThrow(
|
||||
BadRequestException,
|
||||
);
|
||||
|
||||
const dtoFloat = { items: [{ productId: 'prod-1', quantity: 1.5 }] };
|
||||
await expect(service.create('user-id', dtoFloat)).rejects.toThrow(
|
||||
BadRequestException,
|
||||
);
|
||||
});
|
||||
|
||||
it('should throw NotFoundException if any product is not found in batched query', async () => {
|
||||
mockPrisma.product.findMany.mockResolvedValue([
|
||||
{ id: 'prod-1', priceValue: new Prisma.Decimal('1000') },
|
||||
]);
|
||||
const dto = {
|
||||
items: [
|
||||
{ productId: 'prod-1', quantity: 1 },
|
||||
{ productId: 'prod-missing', quantity: 2 },
|
||||
],
|
||||
};
|
||||
await expect(service.create('user-id', dto)).rejects.toThrow(
|
||||
NotFoundException,
|
||||
);
|
||||
});
|
||||
|
||||
it('should successfully create order using batched findMany and precise Decimal calculations', async () => {
|
||||
const products = [
|
||||
{ id: 'prod-1', priceValue: new Prisma.Decimal('32.49') },
|
||||
{ id: 'prod-2', priceValue: new Prisma.Decimal('15.50') },
|
||||
];
|
||||
mockPrisma.product.findMany.mockResolvedValue(products);
|
||||
mockPrisma.order.create.mockResolvedValue({
|
||||
id: 'order-1',
|
||||
totalAmount: 2000,
|
||||
totalAmount: new Prisma.Decimal('80.48'),
|
||||
});
|
||||
|
||||
const dto = { items: [{ productId: 'prod-1', quantity: 2 }] };
|
||||
const dto = {
|
||||
items: [
|
||||
{ productId: 'prod-1', quantity: 2 }, // 32.49 * 2 = 64.98
|
||||
{ productId: 'prod-2', quantity: 1 }, // 15.50 * 1 = 15.50 Total = 80.48
|
||||
],
|
||||
};
|
||||
const result = await service.create('user-id', dto);
|
||||
|
||||
expect(prisma.product.findUnique).toHaveBeenCalledWith({
|
||||
where: { id: 'prod-1' },
|
||||
});
|
||||
expect(prisma.order.create).toHaveBeenCalledWith({
|
||||
data: {
|
||||
userId: 'user-id',
|
||||
totalAmount: 2000,
|
||||
status: 'processing',
|
||||
orderItems: {
|
||||
create: [{ productId: 'prod-1', quantity: 2 }],
|
||||
},
|
||||
},
|
||||
include: {
|
||||
orderItems: {
|
||||
include: { product: true },
|
||||
},
|
||||
},
|
||||
expect(prisma.product.findMany).toHaveBeenCalledWith({
|
||||
where: { id: { in: ['prod-1', 'prod-2'] } },
|
||||
});
|
||||
expect(prisma.order.create).toHaveBeenCalled();
|
||||
expect(result.id).toBe('order-1');
|
||||
});
|
||||
});
|
||||
@@ -114,3 +154,4 @@ describe('OrdersService', () => {
|
||||
});
|
||||
});
|
||||
});
|
||||
|
||||
Reference in new issue
Block a user