Route CI Stage deployment through authenticated pinned SSH host boundary
Deploy Canina / deploy (push) Successful in 4m35s

This commit is contained in:
devops committed 2026-10-23 15:06:24 +00:00
1 parent 6950ff0d79
commit 4b147b0091
4 files changed
+123 -18

No files matched your search

+50
View File
@@ -0,0 +1,50 @@
import os, pathlib, subprocess, tempfile, unittest
ROOT = pathlib.Path(__file__).resolve().parents[2]
class BoundaryTests(unittest.TestCase):
def run_wrapper(self, **updates):
env = dict(os.environ, GITHUB_ACTIONS='true', BRANCH='develop', DEPLOY_SHA='a'*40)
for name in ('DEPLOY_KEY','DEPLOY_KNOWN_HOSTS'): env.pop(name, None)
env.update(updates)
return subprocess.run(['bash', str(ROOT/'scripts/ci-host-deploy.sh')], env=env, capture_output=True, text=True)
def test_missing_pinned_host_identity_fails_before_network(self):
result = self.run_wrapper(DEPLOY_KEY='sentinel-secret')
self.assertNotEqual(result.returncode, 0)
self.assertIn('DEPLOY_KNOWN_HOSTS', result.stderr)
self.assertNotIn('sentinel-secret', result.stdout+result.stderr)
def test_guards_refuse_non_ci_production_and_injection(self):
for updates in ({'GITHUB_ACTIONS':'false'}, {'BRANCH':'main'}, {'DEPLOY_SHA':'a'*40+';touch bad'}, {'DEPLOY_SHA':''}):
result = self.run_wrapper(**updates)
self.assertEqual(result.returncode, 2)
self.assertNotIn('provision', result.stderr)
def test_authentication_is_noninteractive_and_sha_is_only_remote_argument(self):
with tempfile.TemporaryDirectory() as d:
tools = pathlib.Path(d)
# Deliberate transport double: validates invocation, never a live deploy.
(tools/'ssh').write_text('#!/bin/bash\nprintf "%s\\n" "$@" > "$TRACE"\n/bin/cat > "$PAYLOAD"\nexit "${SSH_RESULT:-0}"\n')
(tools/'ssh').chmod(0o755)
known = '[87.248.133.138]:2234 ssh-ed25519 AAAAC3NzaC1lZDI1NTE5AAAAIAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA'
for code in ('0','255'):
result = self.run_wrapper(DEPLOY_KEY='sentinel-secret', DEPLOY_KNOWN_HOSTS=known, PATH=d+':'+os.environ['PATH'], TRACE=d+'/trace', PAYLOAD=d+'/payload', SSH_RESULT=code)
self.assertEqual(result.returncode, int(code), result.stderr)
trace = (tools/'trace').read_text()
for option in ('StrictHostKeyChecking=yes','BatchMode=yes','IdentitiesOnly=yes','IdentityAgent=none','devops@87.248.133.138','sudo -n bash -s -- '+'a'*40): self.assertIn(option,trace)
self.assertNotIn('sentinel-secret', trace+result.stdout+result.stderr)
lines = trace.splitlines()
key = pathlib.Path(lines[lines.index('-i')+1])
self.assertFalse(key.exists(), 'temporary credential must be cleaned even on SSH failure')
payload = (tools/'payload').read_text()
self.assertIn('/raw/commit/${1}/scripts/deploy.sh', payload)
self.assertIn('python3',payload)
self.assertIn('refusing container filesystem',payload)
self.assertNotIn('docker run', payload)
self.assertNotIn('git reset', payload)
def test_workflow_uses_only_authenticated_wrapper(self):
workflow = (ROOT/'.gitea/workflows/deploy.yml').read_text()
self.assertIn('scripts/ci-host-deploy.sh',workflow)
self.assertIn('DEPLOY_KNOWN_HOSTS: ${{ secrets.DEPLOY_KNOWN_HOSTS }}',workflow)
self.assertIn('DEPLOY_KEY: ${{ secrets.DEPLOY_KEY }}',workflow)
self.assertNotIn('cd scripts',workflow)
self.assertNotIn('./deploy.sh',workflow)
if __name__ == '__main__': unittest.main()
+12 -2
View File
@@ -13,7 +13,9 @@ class RolloutTests(unittest.TestCase):
script=(ROOT/'scripts/deploy.sh').read_text()
workflow=(ROOT/'.gitea/workflows/deploy.yml').read_text()
self.assertIn('DEPLOY_SHA: ${{ github.sha }}',workflow)
self.assertIn('/raw/commit/${DEPLOY_SHA}/scripts/deploy.sh',workflow)
self.assertIn('/raw/commit/${DEPLOY_SHA}/scripts/ci-host-deploy.sh',workflow)
wrapper=(ROOT/'scripts/ci-host-deploy.sh').read_text()
self.assertIn('/raw/commit/${1}/scripts/deploy.sh',wrapper)
self.assertNotIn('git reset',script)
self.assertIn('git checkout --detach "$DEPLOY_SHA"',script)
self.assertIn('/opt/services/canina/releases',script)
@@ -34,7 +36,15 @@ class RolloutTests(unittest.TestCase):
workflow=(ROOT/'.gitea/workflows/deploy.yml').read_text()
run=workflow.split(' run: |',1)[1]
self.assertEqual(run.strip().splitlines()[0].strip(),'set -euo pipefail')
self.assertIn('./deploy.sh "${BRANCH}"',run)
self.assertIn('bash "$wrapper"',run)
import textwrap
with tempfile.TemporaryDirectory() as d:
tools=pathlib.Path(d)
(tools/'wget').write_text('#!/bin/sh\nexit 42\n')
(tools/'wget').chmod(0o755)
# Execute the real job block; failed download must not launch wrapper.
result=subprocess.run(['bash','-c',textwrap.dedent(run)], env=dict(os.environ, PATH=d+':'+os.environ['PATH'], BRANCH='develop', DEPLOY_SHA='a'*40, DEPLOY_KEY='test-not-a-key', DEPLOY_KNOWN_HOSTS='test-pin'), capture_output=True,text=True)
self.assertEqual(result.returncode,42,result.stderr)
def test_isolated_deploy_preserves_dirty_stage_and_stable_storage(self):
import json, shutil