From 435a75a442ea5d1873687f91ef9132e61f631eff Mon Sep 17 00:00:00 2001 From: Canina Automation Date: Wed, 28 Oct 2026 12:47:38 +0000 Subject: [PATCH] fix(security): fence corporate orchestration and human key administration --- .../evidence/auth-green.txt | 7 + .../evidence/auth-red3.txt | 104 +++++++ .../evidence/base-full-suite.txt | 207 ++++++++++++++ .../evidence/bounds-red.txt | 44 +++ .../evidence/final-build.txt | 2 + .../evidence/final-green.txt | 8 + .../evidence/full-suite.txt | 207 ++++++++++++++ .../evidence/parent-green.txt | 7 + .../evidence/parent-red.txt | 25 ++ .../evidence/token-green.txt | 7 + .../evidence/token-red.txt | 25 ++ .../corporate-hardening/evidence/url-red.txt | 32 +++ .../evidence/validation-green.txt | 8 + .../evidence/validation-red.txt | 50 ++++ backend/specs/corporate-hardening/plan.md | 3 + backend/specs/corporate-hardening/spec.md | 2 + backend/specs/corporate-hardening/tasks.md | 7 + .../specs/corporate-hardening/verification.md | 14 + backend/src/admin/api-keys.controller.ts | 49 ++-- .../src/admin/api-keys.integration.spec.ts | 127 +++++++++ backend/src/admin/hermes/corporate-policy.ts | 60 +++- .../hermes/corporate.integration.spec.ts | 258 ++++++++++++++++++ backend/src/admin/hermes/corporate.service.ts | 150 ++++++++-- .../src/common/guards/human-admin.guard.ts | 17 ++ 24 files changed, 1366 insertions(+), 54 deletions(-) create mode 100644 backend/specs/corporate-hardening/evidence/auth-green.txt create mode 100644 backend/specs/corporate-hardening/evidence/auth-red3.txt create mode 100644 backend/specs/corporate-hardening/evidence/base-full-suite.txt create mode 100644 backend/specs/corporate-hardening/evidence/bounds-red.txt create mode 100644 backend/specs/corporate-hardening/evidence/final-build.txt create mode 100644 backend/specs/corporate-hardening/evidence/final-green.txt create mode 100644 backend/specs/corporate-hardening/evidence/full-suite.txt create mode 100644 backend/specs/corporate-hardening/evidence/parent-green.txt create mode 100644 backend/specs/corporate-hardening/evidence/parent-red.txt create mode 100644 backend/specs/corporate-hardening/evidence/token-green.txt create mode 100644 backend/specs/corporate-hardening/evidence/token-red.txt create mode 100644 backend/specs/corporate-hardening/evidence/url-red.txt create mode 100644 backend/specs/corporate-hardening/evidence/validation-green.txt create mode 100644 backend/specs/corporate-hardening/evidence/validation-red.txt create mode 100644 backend/specs/corporate-hardening/plan.md create mode 100644 backend/specs/corporate-hardening/spec.md create mode 100644 backend/specs/corporate-hardening/tasks.md create mode 100644 backend/specs/corporate-hardening/verification.md create mode 100644 backend/src/admin/api-keys.integration.spec.ts create mode 100644 backend/src/common/guards/human-admin.guard.ts diff --git a/backend/specs/corporate-hardening/evidence/auth-green.txt b/backend/specs/corporate-hardening/evidence/auth-green.txt new file mode 100644 index 00000000..37060a6a --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/auth-green.txt @@ -0,0 +1,7 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand api-keys.integration.spec +Test Suites: 1 passed, 1 total +Tests: 5 passed, 5 total +Snapshots: 0 total +Time: 4.044 s +Ran all test suites matching api-keys.integration.spec. \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/auth-red3.txt b/backend/specs/corporate-hardening/evidence/auth-red3.txt new file mode 100644 index 00000000..aeebc8bd --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/auth-red3.txt @@ -0,0 +1,104 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand api-keys.integration.spec +FAIL src/admin/api-keys.integration.spec.ts + ● human-only key administration / real key authentication and PostgreSQL › denies get to authenticated admin API key without mutating keys + + expected 403 "Forbidden", got 200 "OK" + + 34 | const before = await db.apiKey.count(); + 35 | const path = '/admin/api-keys' + (method === 'patch' ? `/${target}/toggle` : method === 'delete' ? `/${target}` : ''); + > 36 | await request(app.getHttpServer())[method](path).set('x-api-key', rawKey).send(method === 'post' ? { name: 'security-fixture-forged-reviewer', scopes: ['admin'] } : {}).expect(403); + | ^ + 37 | expect(await db.apiKey.count()).toBe(before); + 38 | expect((await db.apiKey.findUniqueOrThrow({ where: { id: target } })).status).toBe('ACTIVE'); + 39 | }); + + at admin/api-keys.integration.spec.ts:36:174 + ---- + at Test._assertStatus (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:309:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:365:13 + at Test._assertFunction (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:342:13) + at Test.assert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:195:23) + at localAssert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:138:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:156:7 + at Test.fn [as callback] (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:892:12) + at callback (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:1183:18) + at IncomingMessage.fn (../../../corporate-backend/backend/node_modules/superagent/src/node/parsers/json.js:19:7) + + ● human-only key administration / real key authentication and PostgreSQL › denies post to authenticated admin API key without mutating keys + + expected 403 "Forbidden", got 201 "Created" + + 34 | const before = await db.apiKey.count(); + 35 | const path = '/admin/api-keys' + (method === 'patch' ? `/${target}/toggle` : method === 'delete' ? `/${target}` : ''); + > 36 | await request(app.getHttpServer())[method](path).set('x-api-key', rawKey).send(method === 'post' ? { name: 'security-fixture-forged-reviewer', scopes: ['admin'] } : {}).expect(403); + | ^ + 37 | expect(await db.apiKey.count()).toBe(before); + 38 | expect((await db.apiKey.findUniqueOrThrow({ where: { id: target } })).status).toBe('ACTIVE'); + 39 | }); + + at admin/api-keys.integration.spec.ts:36:174 + ---- + at Test._assertStatus (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:309:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:365:13 + at Test._assertFunction (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:342:13) + at Test.assert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:195:23) + at localAssert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:138:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:156:7 + at Test.fn [as callback] (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:892:12) + at callback (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:1183:18) + at IncomingMessage.fn (../../../corporate-backend/backend/node_modules/superagent/src/node/parsers/json.js:19:7) + + ● human-only key administration / real key authentication and PostgreSQL › denies patch to authenticated admin API key without mutating keys + + expected 403 "Forbidden", got 200 "OK" + + 34 | const before = await db.apiKey.count(); + 35 | const path = '/admin/api-keys' + (method === 'patch' ? `/${target}/toggle` : method === 'delete' ? `/${target}` : ''); + > 36 | await request(app.getHttpServer())[method](path).set('x-api-key', rawKey).send(method === 'post' ? { name: 'security-fixture-forged-reviewer', scopes: ['admin'] } : {}).expect(403); + | ^ + 37 | expect(await db.apiKey.count()).toBe(before); + 38 | expect((await db.apiKey.findUniqueOrThrow({ where: { id: target } })).status).toBe('ACTIVE'); + 39 | }); + + at admin/api-keys.integration.spec.ts:36:174 + ---- + at Test._assertStatus (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:309:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:365:13 + at Test._assertFunction (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:342:13) + at Test.assert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:195:23) + at localAssert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:138:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:156:7 + at Test.fn [as callback] (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:892:12) + at callback (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:1183:18) + at IncomingMessage.fn (../../../corporate-backend/backend/node_modules/superagent/src/node/parsers/json.js:19:7) + + ● human-only key administration / real key authentication and PostgreSQL › denies delete to authenticated admin API key without mutating keys + + expected 403 "Forbidden", got 200 "OK" + + 34 | const before = await db.apiKey.count(); + 35 | const path = '/admin/api-keys' + (method === 'patch' ? `/${target}/toggle` : method === 'delete' ? `/${target}` : ''); + > 36 | await request(app.getHttpServer())[method](path).set('x-api-key', rawKey).send(method === 'post' ? { name: 'security-fixture-forged-reviewer', scopes: ['admin'] } : {}).expect(403); + | ^ + 37 | expect(await db.apiKey.count()).toBe(before); + 38 | expect((await db.apiKey.findUniqueOrThrow({ where: { id: target } })).status).toBe('ACTIVE'); + 39 | }); + + at admin/api-keys.integration.spec.ts:36:174 + ---- + at Test._assertStatus (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:309:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:365:13 + at Test._assertFunction (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:342:13) + at Test.assert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:195:23) + at localAssert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:138:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:156:7 + at Test.fn [as callback] (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:892:12) + at callback (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:1183:18) + at IncomingMessage.fn (../../../corporate-backend/backend/node_modules/superagent/src/node/parsers/json.js:19:7) + +Test Suites: 1 failed, 1 total +Tests: 4 failed, 1 passed, 5 total +Snapshots: 0 total +Time: 3.608 s +Ran all test suites matching api-keys.integration.spec. \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/base-full-suite.txt b/backend/specs/corporate-hardening/evidence/base-full-suite.txt new file mode 100644 index 00000000..4370a906 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/base-full-suite.txt @@ -0,0 +1,207 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand +[Nest] 3987292 - 10/28/2026, 12:44:07 PM  ERROR [ZibalEBankService] [Zibal EBank API] Error requesting /ebank/v1/account/list/: transport failed +[Nest] 3987292 - 10/28/2026, 12:44:07 PM  ERROR [ZibalEBankService] [Zibal EBank API] Error requesting /ebank/v1/account/list/: transport failed +[Nest] 3987292 - 10/28/2026, 12:44:22 PM  ERROR [ZibalEBankService] [Zibal EBank API] Error requesting /ebank/v1/account/list/: aborted +[Nest] 3987292 - 10/28/2026, 12:44:07 PM  ERROR [ZibalEBankService] [Zibal EBank API] Error requesting /ebank/v1/account/list/: Zibal EBank HTTP 503 +[Nest] 3987292 - 10/28/2026, 12:44:08 PM  ERROR [SslService] Failed to parse SSL certificate +[Nest] 3987292 - 10/28/2026, 12:44:08 PM  ERROR [SslService] Error: error:0480006C:PEM routines::no start line + at new X509Certificate (node:internal/crypto/x509:121:21) + at SslService.getStatus (/opt/data/cache/scratch/corporate-hardening-base/backend/src/admin/ssl.service.ts:104:20) + at Object. (/opt/data/cache/scratch/corporate-hardening-base/backend/src/admin/ssl.service.spec.ts:179:30) + at Promise.finally.completed (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:1561:28) + at new Promise () + at callAsyncCircusFn (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:1501:10) + at _callCircusTest (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:1011:40) + at _runTest (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:951:3) + at /opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:853:7 + at _runTestsForDescribeBlock (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:866:11) + at _runTestsForDescribeBlock (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:861:11) + at _runTestsForDescribeBlock (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:861:11) + at run (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:765:3) + at runAndTransformResultsToJestFormat (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:1993:21) + at jestAdapter (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/runner.js:111:19) + at runTestInternal (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-runner/build/index.js:276:16) + at runTest (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-runner/build/index.js:344:7) { + library: 'PEM routines', + reason: 'no start line', + code: 'ERR_OSSL_PEM_NO_START_LINE' +} +[Nest] 3987292 - 10/28/2026, 12:44:12 PM  ERROR [PaymentService] Security Alert: Amount mismatch on trackId=tr-1! Zibal reported 1000000 Rials, but expected 5000000 Rials in DB. +FAIL src/seo-tracking/publication.postgres.spec.ts + ● Test suite failed to run + + PrismaClientConstructorValidationError: Invalid value undefined for datasource "db" provided to PrismaClient constructor. + It should have this form: { url: "CONNECTION_STRING" } + Read more at https://pris.ly/d/client-constructor + + 20 | const deferred = () => { let resolve!: () => void; const promise = new Promise(r => resolve = r); return { promise, resolve }; }; + 21 | (url ? describe : describe.skip)('atomic publication: real PostgreSQL row ordering', () => { + > 22 | const db = new PrismaClient({ datasources: { db: { url } } }); + | ^ + 23 | let user: any; + 24 | const cache = { revalidateBlog: jest.fn(async () => false) }; + 25 | const service = new SeoTrackingService(db as any, cache as any); + + at Object.datasources (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:124:86) + at Gl (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:126:2527) + at new t (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:130:748) + at seo-tracking/publication.postgres.spec.ts:22:14 + at Object. (seo-tracking/publication.postgres.spec.ts:21:33) + +[Nest] 3987292 - 10/28/2026, 12:44:18 PM  WARN [BlogsService] Cache revalidation failed for updated blog [post]: cache down +FAIL src/wiki/wiki.service.spec.ts + ● WikiService › findAll › should paginate and filter terms with fallback to default sortBy + + expect(jest.fn()).toHaveBeenCalledWith(...expected) + + - Expected + + Received + + @@ -1,21 +1,39 @@ + Object { + "orderBy": Object { + "term": "desc", + }, + - "skip": 0, + - "take": 10, + + "skip": undefined, + + "take": 100, + "where": Object { + "OR": Array [ + Object { + "term": Object { + "contains": "مفصل", + "mode": "insensitive", + }, + }, + Object { + + "key": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + "definition": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + + "term": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + + "key": Object { + "contains": "مفصل", + "mode": "insensitive", + }, + }, + ],, + + Number of calls: 1 + + 56 | }); + 57 | + > 58 | expect(mockPrisma.scientificTerm.findMany).toHaveBeenCalledWith({ + | ^ + 59 | where: { + 60 | OR: [ + 61 | { term: { contains: "مفصل", mode: "insensitive" } }, + + at Object. (wiki/wiki.service.spec.ts:58:50) + + +Summary of all failing tests +FAIL seo-tracking/publication.postgres.spec.ts + ● Test suite failed to run + + PrismaClientConstructorValidationError: Invalid value undefined for datasource "db" provided to PrismaClient constructor. + It should have this form: { url: "CONNECTION_STRING" } + Read more at https://pris.ly/d/client-constructor + + 20 | const deferred = () => { let resolve!: () => void; const promise = new Promise(r => resolve = r); return { promise, resolve }; }; + 21 | (url ? describe : describe.skip)('atomic publication: real PostgreSQL row ordering', () => { + > 22 | const db = new PrismaClient({ datasources: { db: { url } } }); + | ^ + 23 | let user: any; + 24 | const cache = { revalidateBlog: jest.fn(async () => false) }; + 25 | const service = new SeoTrackingService(db as any, cache as any); + + at Object.datasources (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:124:86) + at Gl (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:126:2527) + at new t (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:130:748) + at seo-tracking/publication.postgres.spec.ts:22:14 + at Object. (seo-tracking/publication.postgres.spec.ts:21:33) + +FAIL wiki/wiki.service.spec.ts + ● WikiService › findAll › should paginate and filter terms with fallback to default sortBy + + expect(jest.fn()).toHaveBeenCalledWith(...expected) + + - Expected + + Received + + @@ -1,21 +1,39 @@ + Object { + "orderBy": Object { + "term": "desc", + }, + - "skip": 0, + - "take": 10, + + "skip": undefined, + + "take": 100, + "where": Object { + "OR": Array [ + Object { + "term": Object { + "contains": "مفصل", + "mode": "insensitive", + }, + }, + Object { + + "key": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + "definition": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + + "term": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + + "key": Object { + "contains": "مفصل", + "mode": "insensitive", + }, + }, + ],, + + Number of calls: 1 + + 56 | }); + 57 | + > 58 | expect(mockPrisma.scientificTerm.findMany).toHaveBeenCalledWith({ + | ^ + 59 | where: { + 60 | OR: [ + 61 | { term: { contains: "مفصل", mode: "insensitive" } }, + + at Object. (wiki/wiki.service.spec.ts:58:50) + + +Test Suites: 2 failed, 5 skipped, 95 passed, 97 of 102 total +Tests: 1 failed, 13 skipped, 818 passed, 832 total +Snapshots: 0 total +Time: 55.893 s +Ran all test suites. \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/bounds-red.txt b/backend/specs/corporate-hardening/evidence/bounds-red.txt new file mode 100644 index 00000000..7bdd19e4 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/bounds-red.txt @@ -0,0 +1,44 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec -t bounds detail|oversized +FAIL src/admin/hermes/corporate.integration.spec.ts + ● corporate API / disposable PostgreSQL › bounds detail relations and report snapshots with explicit truncation and immutable replay + + expect(received).toHaveLength(expected) + + Expected length: 100 + Received length: 106 + Received array: [[Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], [Object], …] + + 153 | await db.corporateEvent.createMany({ data: Array.from({ length: 105 }, () => ({ taskId: task.id, speaker: 'SYSTEM', speakerName: 'fixture', step: 'FIXTURE', content: 'x'.repeat(10000), payload: { nested: ['x'.repeat(10000)] } })) }); + 154 | const detail = await request(app.getHttpServer()).get('/admin/hermes/tasks/' + task.id).set('x-api-key', 'executor').expect(200); + > 155 | expect(detail.body.logs).toHaveLength(100); + | ^ + 156 | expect(detail.body.relationsMeta.logs).toEqual({ total: 106, returned: 100, limit: 100, truncated: true }); + 157 | const op = key(), body = { day: new Date().toISOString().slice(0, 10), summary: 'bounded' }; + 158 | const report = (await post('reports', body, 'executor', op).expect(201)).body; + + at Object. (admin/hermes/corporate.integration.spec.ts:155:30) + + ● corporate API / disposable PostgreSQL › rolls back oversized mutation responses instead of persisting huge idempotency values + + expect(received).rejects.toThrow() + + Received promise resolved instead of rejected + Resolved to value: {"value": "xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx + + 168 | const service = app.get(CorporateService) as any; + 169 | const before = await db.corporateTask.count(); + > 170 | await expect(service.operation('fixture', 'oversize', key(), {}, async (tx: any) => { + | ^ + 171 | await tx.corporateTask.create({ data: { title: 'rollback', description: 'fixture', taskCode: key(), normalizedTitle: 'rollback', normalizedCode: key(), department: 'CONTENT_SEO', createdBy: 'fixture' } }); + 172 | return { value: 'x'.repeat(1100000) }; + 173 | })).rejects.toThrow('Operation response exceeds limit'); + + at expect (../../../corporate-backend/backend/node_modules/expect/build/index.js:2116:15) + at Object. (admin/hermes/corporate.integration.spec.ts:170:11) + +Test Suites: 1 failed, 1 total +Tests: 2 failed, 10 skipped, 12 total +Snapshots: 0 total +Time: 4.583 s +Ran all test suites matching corporate.integration.spec with tests matching "bounds detail|oversized". \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/final-build.txt b/backend/specs/corporate-hardening/evidence/final-build.txt new file mode 100644 index 00000000..68fa697c --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/final-build.txt @@ -0,0 +1,2 @@ +npm notice run backend@0.0.1 build +npm notice run tsc -b \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/final-green.txt b/backend/specs/corporate-hardening/evidence/final-green.txt new file mode 100644 index 00000000..31313ab1 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/final-green.txt @@ -0,0 +1,8 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec corporate-policy.spec api-keys.integration.spec + +Test Suites: 3 passed, 3 total +Tests: 20 passed, 20 total +Snapshots: 0 total +Time: 9.263 s +Ran all test suites matching corporate.integration.spec|corporate-policy.spec|api-keys.integration.spec. \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/full-suite.txt b/backend/specs/corporate-hardening/evidence/full-suite.txt new file mode 100644 index 00000000..3d2d9dc7 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/full-suite.txt @@ -0,0 +1,207 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand +[Nest] 3985069 - 10/28/2026, 12:42:14 PM  ERROR [ZibalEBankService] [Zibal EBank API] Error requesting /ebank/v1/account/list/: transport failed +[Nest] 3985069 - 10/28/2026, 12:42:14 PM  ERROR [ZibalEBankService] [Zibal EBank API] Error requesting /ebank/v1/account/list/: transport failed +[Nest] 3985069 - 10/28/2026, 12:42:29 PM  ERROR [ZibalEBankService] [Zibal EBank API] Error requesting /ebank/v1/account/list/: aborted +[Nest] 3985069 - 10/28/2026, 12:42:14 PM  ERROR [ZibalEBankService] [Zibal EBank API] Error requesting /ebank/v1/account/list/: Zibal EBank HTTP 503 +[Nest] 3985069 - 10/28/2026, 12:42:15 PM  ERROR [SslService] Failed to parse SSL certificate +[Nest] 3985069 - 10/28/2026, 12:42:15 PM  ERROR [SslService] Error: error:0480006C:PEM routines::no start line + at new X509Certificate (node:internal/crypto/x509:121:21) + at SslService.getStatus (/opt/data/cache/scratch/corporate-hardening/backend/src/admin/ssl.service.ts:104:20) + at Object. (/opt/data/cache/scratch/corporate-hardening/backend/src/admin/ssl.service.spec.ts:179:30) + at Promise.finally.completed (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:1561:28) + at new Promise () + at callAsyncCircusFn (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:1501:10) + at _callCircusTest (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:1011:40) + at _runTest (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:951:3) + at /opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:853:7 + at _runTestsForDescribeBlock (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:866:11) + at _runTestsForDescribeBlock (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:861:11) + at _runTestsForDescribeBlock (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:861:11) + at run (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:765:3) + at runAndTransformResultsToJestFormat (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/jestAdapterInit.js:1993:21) + at jestAdapter (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-circus/build/runner.js:111:19) + at runTestInternal (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-runner/build/index.js:276:16) + at runTest (/opt/data/cache/scratch/corporate-backend/backend/node_modules/jest-runner/build/index.js:344:7) { + library: 'PEM routines', + reason: 'no start line', + code: 'ERR_OSSL_PEM_NO_START_LINE' +} +[Nest] 3985069 - 10/28/2026, 12:42:19 PM  ERROR [PaymentService] Security Alert: Amount mismatch on trackId=tr-1! Zibal reported 1000000 Rials, but expected 5000000 Rials in DB. +FAIL src/seo-tracking/publication.postgres.spec.ts + ● Test suite failed to run + + PrismaClientConstructorValidationError: Invalid value undefined for datasource "db" provided to PrismaClient constructor. + It should have this form: { url: "CONNECTION_STRING" } + Read more at https://pris.ly/d/client-constructor + + 20 | const deferred = () => { let resolve!: () => void; const promise = new Promise(r => resolve = r); return { promise, resolve }; }; + 21 | (url ? describe : describe.skip)('atomic publication: real PostgreSQL row ordering', () => { + > 22 | const db = new PrismaClient({ datasources: { db: { url } } }); + | ^ + 23 | let user: any; + 24 | const cache = { revalidateBlog: jest.fn(async () => false) }; + 25 | const service = new SeoTrackingService(db as any, cache as any); + + at Object.datasources (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:124:86) + at Gl (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:126:2527) + at new t (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:130:748) + at seo-tracking/publication.postgres.spec.ts:22:14 + at Object. (seo-tracking/publication.postgres.spec.ts:21:33) + +[Nest] 3985069 - 10/28/2026, 12:42:26 PM  WARN [BlogsService] Cache revalidation failed for updated blog [post]: cache down +FAIL src/wiki/wiki.service.spec.ts + ● WikiService › findAll › should paginate and filter terms with fallback to default sortBy + + expect(jest.fn()).toHaveBeenCalledWith(...expected) + + - Expected + + Received + + @@ -1,21 +1,39 @@ + Object { + "orderBy": Object { + "term": "desc", + }, + - "skip": 0, + - "take": 10, + + "skip": undefined, + + "take": 100, + "where": Object { + "OR": Array [ + Object { + "term": Object { + "contains": "مفصل", + "mode": "insensitive", + }, + }, + Object { + + "key": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + "definition": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + + "term": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + + "key": Object { + "contains": "مفصل", + "mode": "insensitive", + }, + }, + ],, + + Number of calls: 1 + + 56 | }); + 57 | + > 58 | expect(mockPrisma.scientificTerm.findMany).toHaveBeenCalledWith({ + | ^ + 59 | where: { + 60 | OR: [ + 61 | { term: { contains: "مفصل", mode: "insensitive" } }, + + at Object. (wiki/wiki.service.spec.ts:58:50) + + +Summary of all failing tests +FAIL seo-tracking/publication.postgres.spec.ts + ● Test suite failed to run + + PrismaClientConstructorValidationError: Invalid value undefined for datasource "db" provided to PrismaClient constructor. + It should have this form: { url: "CONNECTION_STRING" } + Read more at https://pris.ly/d/client-constructor + + 20 | const deferred = () => { let resolve!: () => void; const promise = new Promise(r => resolve = r); return { promise, resolve }; }; + 21 | (url ? describe : describe.skip)('atomic publication: real PostgreSQL row ordering', () => { + > 22 | const db = new PrismaClient({ datasources: { db: { url } } }); + | ^ + 23 | let user: any; + 24 | const cache = { revalidateBlog: jest.fn(async () => false) }; + 25 | const service = new SeoTrackingService(db as any, cache as any); + + at Object.datasources (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:124:86) + at Gl (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:126:2527) + at new t (../../../corporate-backend/backend/node_modules/@prisma/client/runtime/library.js:130:748) + at seo-tracking/publication.postgres.spec.ts:22:14 + at Object. (seo-tracking/publication.postgres.spec.ts:21:33) + +FAIL wiki/wiki.service.spec.ts + ● WikiService › findAll › should paginate and filter terms with fallback to default sortBy + + expect(jest.fn()).toHaveBeenCalledWith(...expected) + + - Expected + + Received + + @@ -1,21 +1,39 @@ + Object { + "orderBy": Object { + "term": "desc", + }, + - "skip": 0, + - "take": 10, + + "skip": undefined, + + "take": 100, + "where": Object { + "OR": Array [ + Object { + "term": Object { + "contains": "مفصل", + "mode": "insensitive", + }, + }, + Object { + + "key": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + "definition": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + + "term": Object { + + "contains": "مفصل", + + "mode": "insensitive", + + }, + + }, + + Object { + + "key": Object { + "contains": "مفصل", + "mode": "insensitive", + }, + }, + ],, + + Number of calls: 1 + + 56 | }); + 57 | + > 58 | expect(mockPrisma.scientificTerm.findMany).toHaveBeenCalledWith({ + | ^ + 59 | where: { + 60 | OR: [ + 61 | { term: { contains: "مفصل", mode: "insensitive" } }, + + at Object. (wiki/wiki.service.spec.ts:58:50) + + +Test Suites: 2 failed, 6 skipped, 95 passed, 97 of 103 total +Tests: 1 failed, 25 skipped, 818 passed, 844 total +Snapshots: 0 total +Time: 56.587 s +Ran all test suites. \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/parent-green.txt b/backend/specs/corporate-hardening/evidence/parent-green.txt new file mode 100644 index 00000000..542966a9 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/parent-green.txt @@ -0,0 +1,7 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec +Test Suites: 1 passed, 1 total +Tests: 7 passed, 7 total +Snapshots: 0 total +Time: 6.041 s +Ran all test suites matching corporate.integration.spec. \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/parent-red.txt b/backend/specs/corporate-hardening/evidence/parent-red.txt new file mode 100644 index 00000000..b96fd238 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/parent-red.txt @@ -0,0 +1,25 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec -t rejects children +FAIL src/admin/hermes/corporate.integration.spec.ts + ● corporate API / disposable PostgreSQL › rejects children after a parent claim commits while child creation waits on its row lock + + expect(received).toBe(expected) // Object.is equality + + Expected: 409 + Received: 201 + + 103 | expect(waiting).toBe(true); + 104 | } finally { release(); await claiming; } + > 105 | expect((await pending).status).toBe(409); + | ^ + 106 | expect(await db.corporateTask.count({ where: { parentId: parent.id } })).toBe(0); + 107 | }); + 108 | it('accepts children on TODO and BLOCKED, which prevents parent claiming', async () => { + + at Object. (admin/hermes/corporate.integration.spec.ts:105:36) + +Test Suites: 1 failed, 1 total +Tests: 1 failed, 6 skipped, 7 total +Snapshots: 0 total +Time: 4.263 s +Ran all test suites matching corporate.integration.spec with tests matching "rejects children". \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/token-green.txt b/backend/specs/corporate-hardening/evidence/token-green.txt new file mode 100644 index 00000000..aba98427 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/token-green.txt @@ -0,0 +1,7 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec -t public reads +Test Suites: 1 passed, 1 total +Tests: 9 skipped, 1 passed, 10 total +Snapshots: 0 total +Time: 4.131 s +Ran all test suites matching corporate.integration.spec with tests matching "public reads". \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/token-red.txt b/backend/specs/corporate-hardening/evidence/token-red.txt new file mode 100644 index 00000000..f6cabde0 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/token-red.txt @@ -0,0 +1,25 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec -t public reads +FAIL src/admin/hermes/corporate.integration.spec.ts + ● corporate API / disposable PostgreSQL › public reads strip claim tokens recursively while claim and replay retain ownership token + + expect(received).not.toContain(expected) // indexOf + + Expected substring: not "claimToken" + Received string: "{\"data\":[{\"id\":\"df2e8641-026a-4ed0-80ca-36fc10db3b3c\",\"taskCode\":\"TSK-257421eb-e384-403f-837c-f09345000cf2\",\"title\":\"كيك ۱۲۳\",\"normalizedTitle\":\"کیک 123\",\"normalizedCode\":\"tsk-257421eb-e384-403f-837c-f09345000cf2\",\"description\":\"integration fixture\",\"department\":\"CONTENT_SEO\",\"priority\":\"CEO_EXPEDITE\",\"status\":\"TEST\",\"actionType\":\"CEO_DIRECTIVE\",\"dueCycle\":null,\"parentId\":\"cb3407eb-35f4-4a02-9c5e-993e2b5924f1\",\"goalId\":null,\"assignedAgent\":\"apikey:executor\",\"claimToken\":\"b57fc669-e7c8-41c3-8904-f3bc60d2dc51\",\"leasedUntil\":null,\"executionCount\":1,\"qaCount\":0,\"rejectionCount\":0,\"createdBy\":\"apikey:executor\",\"createdAt\":\"2026-10-28T12:37:42.198Z\",\"updatedAt\":\"2026-10-28T12:37:42.296Z\"},{\"id\":\"cb3407eb-35f4-4a02-9c5e-993e2b5924f1\",\"taskCode\":\"TSK-40ee89e7-7127-4e85-aac2-dad7ea156be6\",\"title\":\"كيك ۱۲۳\",\"normalizedTitle\":\"کیک 123\",\"normalizedCode\":\"tsk-40ee89e7-7127-4 + + 145 | for (const path of ['tasks', 'tasks/' + child.id, 'tasks/' + parent.id]) { + 146 | const r = await request(app.getHttpServer()).get('/admin/hermes/' + path).set('x-api-key', 'competitor').expect(200); + > 147 | expect(JSON.stringify(r.body)).not.toContain('claimToken'); + | ^ + 148 | expect(JSON.stringify(r.body)).not.toContain(claim.claimToken); + 149 | } + 150 | }); + + at Object. (admin/hermes/corporate.integration.spec.ts:147:42) + +Test Suites: 1 failed, 1 total +Tests: 1 failed, 9 skipped, 10 total +Snapshots: 0 total +Time: 3.842 s, estimated 6 s +Ran all test suites matching corporate.integration.spec with tests matching "public reads". \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/url-red.txt b/backend/specs/corporate-hardening/evidence/url-red.txt new file mode 100644 index 00000000..a73f65da --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/url-red.txt @@ -0,0 +1,32 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec -t malformed +FAIL src/admin/hermes/corporate.integration.spec.ts + ● corporate API / disposable PostgreSQL › rejects malformed artifact locators and mismatched digest URNs before persistence + + expected 400 "Bad Request", got 201 "Created" + + 166 | 'urn:sha256:' + 'b'.repeat(64), + 167 | ]) { + > 168 | await post(`tasks/${task.id}/evidence`, { ...body, artifactUri }).expect( + | ^ + 169 | 400, + 170 | ); + 171 | } + + at Object. (admin/hermes/corporate.integration.spec.ts:168:73) + ---- + at Test._assertStatus (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:309:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:365:13 + at Test._assertFunction (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:342:13) + at Test.assert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:195:23) + at localAssert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:138:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:156:7 + at Test.fn [as callback] (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:892:12) + at callback (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:1183:18) + at IncomingMessage.fn (../../../corporate-backend/backend/node_modules/superagent/src/node/parsers/json.js:19:7) + +Test Suites: 1 failed, 1 total +Tests: 1 failed, 11 skipped, 12 total +Snapshots: 0 total +Time: 3.923 s, estimated 8 s +Ran all test suites matching corporate.integration.spec with tests matching "malformed". \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/validation-green.txt b/backend/specs/corporate-hardening/evidence/validation-green.txt new file mode 100644 index 00000000..1110463e --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/validation-green.txt @@ -0,0 +1,8 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec corporate-policy.spec + +Test Suites: 2 passed, 2 total +Tests: 12 passed, 12 total +Snapshots: 0 total +Time: 6.595 s +Ran all test suites matching corporate.integration.spec|corporate-policy.spec. \ No newline at end of file diff --git a/backend/specs/corporate-hardening/evidence/validation-red.txt b/backend/specs/corporate-hardening/evidence/validation-red.txt new file mode 100644 index 00000000..883ac9f4 --- /dev/null +++ b/backend/specs/corporate-hardening/evidence/validation-red.txt @@ -0,0 +1,50 @@ +npm notice run backend@0.0.1 test +npm notice run jest --runInBand corporate.integration.spec -t malformed|coercions +FAIL src/admin/hermes/corporate.integration.spec.ts + ● corporate API / disposable PostgreSQL › rejects malformed artifact locators and mismatched digest URNs before persistence + + expected 400 "Bad Request", got 201 "Created" + + 119 | const body = { claimToken: claim.claimToken, artifactUri: '', sha256: 'a'.repeat(64), summary: 'receipt', tool: 'jest', result: 'passed' }; + 120 | for (const artifactUri of ['https://', 'https://?x', 'https://bad host/x', 'https://user:pass@host.org/a', 'https://localhost/a', 'https://127.1/a', 'https://[::1]/a', 'urn:sha256:', 'urn:sha256:' + 'b'.repeat(64)]) { + > 121 | await post(`tasks/${task.id}/evidence`, { ...body, artifactUri }).expect(400); + | ^ + 122 | } + 123 | expect(await db.corporateEvidence.count()).toBe(0); + 124 | await post(`tasks/${task.id}/evidence`, { ...body, artifactUri: 'https://pubmed.ncbi.nlm.nih.gov/123/' }).expect(201); + + at Object. (admin/hermes/corporate.integration.spec.ts:121:73) + ---- + at Test._assertStatus (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:309:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:365:13 + at Test._assertFunction (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:342:13) + at Test.assert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:195:23) + at localAssert (../../../corporate-backend/backend/node_modules/supertest/lib/test.js:138:14) + at ../../../corporate-backend/backend/node_modules/supertest/lib/test.js:156:7 + at Test.fn [as callback] (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:892:12) + at callback (../../../corporate-backend/backend/node_modules/superagent/src/node/index.js:1183:18) + at IncomingMessage.fn (../../../corporate-backend/backend/node_modules/superagent/src/node/parsers/json.js:19:7) + + ● corporate API / disposable PostgreSQL › rejects implicit timestamp coercions in source and effect inputs + + expect(received).rejects.toThrow() + + Received promise resolved instead of rejected + Resolved to value: {"cadence": "MONTHLY", "category": "TREND", "createdAt": "2026-10-28T12:34:28.558Z", "createdBy": "fixture", "id": "8c847ae0-ff80-4ba2-9986-26a2abdd167a", "impact": "LOW", "opportunity": "investigate", "provenance": {"collector": "fixture", "context": "isolated", "method": "test"}, "recommendedAction": "measure", "source": "receipt", "sources": [{"excerpt": "receipt", "id": "108f61d9-0e90-4d53-804e-0330d129a299", "researchId": "8c847ae0-ff80-4ba2-9986-26a2abdd167a", "retrievedAt": "1970-01-01T00:00:00.000Z", "sha256": "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "title": "source", "url": "https://pubmed.ncbi.nlm.nih.gov/"}], "status": "DISCOVERED", "title": "research"} + + 128 | const research = { title: 'research', category: 'TREND', source: 'receipt', opportunity: 'investigate', impact: 'LOW', recommendedAction: 'measure', cadence: 'MONTHLY', provenance: { method: 'test', collector: 'fixture', context: 'isolated' }, sources: [{ url: 'https://pubmed.ncbi.nlm.nih.gov/', title: 'source', excerpt: 'receipt', retrievedAt: '', sha256: 'a'.repeat(64) }] }; + 129 | for (const time of [null, 0, false, [], '2026-01-01', '2026-02-30T00:00:00Z']) { + > 130 | await expect(service.research('fixture', key(), { ...research, sources: [{ ...research.sources[0], retrievedAt: time }] })).rejects.toThrow(); + | ^ + 131 | await expect(service.effect('fixture', key(), key(), { metric: 'views', availability: 'UNAVAILABLE', source: 'none', observedAt: time })).rejects.toThrow('Invalid observation time'); + 132 | } + 133 | for (const url of ['https://', 'https://?bad', 'https://bad host']) + + at expect (../../../corporate-backend/backend/node_modules/expect/build/index.js:2116:15) + at Object. (admin/hermes/corporate.integration.spec.ts:130:13) + +Test Suites: 1 failed, 1 total +Tests: 2 failed, 7 skipped, 9 total +Snapshots: 0 total +Time: 3.997 s, estimated 6 s +Ran all test suites matching corporate.integration.spec with tests matching "malformed|coercions". \ No newline at end of file diff --git a/backend/specs/corporate-hardening/plan.md b/backend/specs/corporate-hardening/plan.md new file mode 100644 index 00000000..e9c3c999 --- /dev/null +++ b/backend/specs/corporate-hardening/plan.md @@ -0,0 +1,3 @@ +# Plan +Dedicated human-principal guard after authentication and role guard. Keep scope rules unchanged. Reuse parent row lock. Centralize locator/time validation and public projection. Bound detail/report queries with deterministic ordering, counts and metadata; cap serialized operation responses. +Graph navigation: graphify-out/graph.json sha256 6a73473cee9e207543fdeeb668bea544f766200a1b16b8a3a9ce18d4e42e51af, 4304 nodes, build provenance unverified (navigation only). ApiKeysController -> JwtAuthGuard -> ApiKeysService verified directly at cc365bc; CorporateController -> CorporateService -> Prisma verified directly (corporate absent from stale map). \ No newline at end of file diff --git a/backend/specs/corporate-hardening/spec.md b/backend/specs/corporate-hardening/spec.md new file mode 100644 index 00000000..1cc731d4 --- /dev/null +++ b/backend/specs/corporate-hardening/spec.md @@ -0,0 +1,2 @@ +# Corporate hardening +Base cc365bc. Backend only, no push/deploy. Humans retain admin key management; API keys cannot manage keys. Children attach only to TODO/BLOCKED under parent lock. Validate HTTPS locators/digest URNs and explicit ISO timestamp strings. Public reads omit claimToken recursively; claim retains it. Detail relations and report snapshots bounded with truncation metadata and idempotency response size guard. Acceptance: real disposable PG HTTP tests, ordering tests, backend build. \ No newline at end of file diff --git a/backend/specs/corporate-hardening/tasks.md b/backend/specs/corporate-hardening/tasks.md new file mode 100644 index 00000000..3343e882 --- /dev/null +++ b/backend/specs/corporate-hardening/tasks.md @@ -0,0 +1,7 @@ +# Tasks +- [x] RED/GREEN human key-admin gate with real key authentication +- [x] RED/GREEN parent ordering on PostgreSQL +- [x] RED/GREEN locator/time validation +- [x] RED/GREEN public token projection +- [x] RED/GREEN bounded reads/report/replay +- [x] regression suite, backend build, commit (no push) \ No newline at end of file diff --git a/backend/specs/corporate-hardening/verification.md b/backend/specs/corporate-hardening/verification.md new file mode 100644 index 00000000..9a25b369 --- /dev/null +++ b/backend/specs/corporate-hardening/verification.md @@ -0,0 +1,14 @@ +# Verification +Base cc365bc; backend isolated branch hardening/corporate-security. No push/deploy/runtime changes. + +Real PostgreSQL 16.2 started locally on 127.0.0.1:55439, corporate_test. Prisma db push applied only to disposable fixture (existing fixture lacked api_keys); tests use explicit opt-in, never runtime DATABASE_URL. Dependencies symlinked from corporate-backend/backend/node_modules, unchanged lockfile. + +- RED auth: four key-management verbs returned 200/201 instead of 403 with real ApiKeysService validation against PG. GREEN 5 tests. Human path uses signed test-only Passport strategy (does not claim production JWT user lookup). +- RED parent: child HTTP request observed waiting on PostgreSQL parent row lock; after IN_PROGRESS commit returned 201 instead of 409. GREEN includes TODO/BLOCKED child-first gating, existing SKIP LOCKED coverage. +- RED validation: malformed HTTPS accepted, null timestamp persisted as epoch. GREEN malformed hosts, userinfo, loopback, malformed/mismatched digest URN, numeric/null/boolean/array/date-only/invalid calendar timestamp rejected. +- RED projection: public reads exposed claimToken. GREEN list/detail/evidence/children omit it; claim and immutable claim replay retain ownership token. +- RED bounds: detail returned 106 logs and oversized response persisted. GREEN limits 100 for each detail relation/report section, counts/truncation metadata, report 1000-character fields and omitted payloads; immutable report replay after source deletion; oversized operation rolls back task and operation. +- Final targeted: 3 suites / 20 tests passed with real PG enabled. Backend tsc -b passed. +- Full suite without opt-in: 95 passed suites, 2 failed, 6 skipped; 818 passed tests, 1 failed, 25 skipped. Exact clean cc365bc same dependencies: 95 passed suites, same 2 failed (publication.postgres undefined datasource in skipped describe; wiki stale pagination/search expectation), 5 skipped; 818 passed, same 1 failed, 13 skipped. Extra skips are new/expanded opt-in security tests, not regressions. + +Report snapshot is intentionally partial, not a complete daily export. Relation metadata supports explicit partial display; no frontend changes owned here. Public detail relation count is capped, not arbitrary legacy JSON field bytes. All newly created idempotency responses capped at 1,000,000 UTF-8 bytes before durable save; rejection rolls back transaction. Existing legacy idempotency records are unchanged. diff --git a/backend/src/admin/api-keys.controller.ts b/backend/src/admin/api-keys.controller.ts index 1d45e5ce..016338a9 100644 --- a/backend/src/admin/api-keys.controller.ts +++ b/backend/src/admin/api-keys.controller.ts @@ -8,33 +8,34 @@ import { Param, UseGuards, HttpStatus, -} from "@nestjs/common"; -import { ApiKeysService } from "./api-keys.service"; -import { CreateApiKeyDto } from "./dto/api-key.dto"; -import { JwtAuthGuard } from "../auth/jwt-auth.guard"; +} from '@nestjs/common'; +import { ApiKeysService } from './api-keys.service'; +import { CreateApiKeyDto } from './dto/api-key.dto'; +import { JwtAuthGuard } from '../auth/jwt-auth.guard'; import { ApiTags, ApiBearerAuth, ApiOperation, ApiResponse, -} from "@nestjs/swagger"; +} from '@nestjs/swagger'; -import { RolesGuard } from "../common/guards/roles.guard"; -import { Roles } from "../common/decorators/roles.decorator"; +import { RolesGuard } from '../common/guards/roles.guard'; +import { HumanAdminGuard } from '../common/guards/human-admin.guard'; +import { Roles } from '../common/decorators/roles.decorator'; -@ApiTags("Admin - مدیریت کلیدهای دسترسی (API Keys)") +@ApiTags('Admin - مدیریت کلیدهای دسترسی (API Keys)') @ApiBearerAuth() -@UseGuards(JwtAuthGuard, RolesGuard) -@Roles("Admin", "SUPER_ADMIN") -@Controller("admin/api-keys") +@UseGuards(JwtAuthGuard, RolesGuard, HumanAdminGuard) +@Roles('Admin', 'SUPER_ADMIN') +@Controller('admin/api-keys') export class ApiKeysController { constructor(private readonly apiKeysService: ApiKeysService) {} @Get() - @ApiOperation({ summary: "دریافت لیست کلیدهای دسترسی API" }) + @ApiOperation({ summary: 'دریافت لیست کلیدهای دسترسی API' }) @ApiResponse({ status: HttpStatus.OK, - description: "لیست کلیدها با موفقیت دریافت شد", + description: 'لیست کلیدها با موفقیت دریافت شد', }) async findAll() { const keys = await this.apiKeysService.findAll(); @@ -45,39 +46,39 @@ export class ApiKeysController { } @Post() - @ApiOperation({ summary: "ایجاد یک API Key جدید" }) + @ApiOperation({ summary: 'ایجاد یک API Key جدید' }) @ApiResponse({ status: HttpStatus.CREATED, - description: "کلید جدید با موفقیت ایجاد شد", + description: 'کلید جدید با موفقیت ایجاد شد', }) async create(@Body() dto: CreateApiKeyDto) { const result = await this.apiKeysService.create(dto); return { success: true, message: - "کلید دسترسی با موفقیت ایجاد شد. لطفاً آن را در جای امن ذخیره نمایید.", + 'کلید دسترسی با موفقیت ایجاد شد. لطفاً آن را در جای امن ذخیره نمایید.', data: result, }; } - @Patch(":id/toggle") - @ApiOperation({ summary: "تغییر وضعیت فعال/غیرفعال کلید" }) - async toggleStatus(@Param("id") id: string) { + @Patch(':id/toggle') + @ApiOperation({ summary: 'تغییر وضعیت فعال/غیرفعال کلید' }) + async toggleStatus(@Param('id') id: string) { const updated = await this.apiKeysService.toggleStatus(id); return { success: true, - message: "وضعیت کلید با موفقیت به‌روزرسانی شد", + message: 'وضعیت کلید با موفقیت به‌روزرسانی شد', data: updated, }; } - @Delete(":id") - @ApiOperation({ summary: "حذف کلید دسترسی" }) - async delete(@Param("id") id: string) { + @Delete(':id') + @ApiOperation({ summary: 'حذف کلید دسترسی' }) + async delete(@Param('id') id: string) { await this.apiKeysService.delete(id); return { success: true, - message: "کلید دسترسی با موفقیت حذف شد", + message: 'کلید دسترسی با موفقیت حذف شد', }; } } diff --git a/backend/src/admin/api-keys.integration.spec.ts b/backend/src/admin/api-keys.integration.spec.ts new file mode 100644 index 00000000..3217ec39 --- /dev/null +++ b/backend/src/admin/api-keys.integration.spec.ts @@ -0,0 +1,127 @@ +import passport from 'passport'; +import { Strategy, ExtractJwt } from 'passport-jwt'; +import { sign } from 'jsonwebtoken'; +import { PrismaClient } from '@prisma/client'; +import { Test } from '@nestjs/testing'; +import { INestApplication } from '@nestjs/common'; +import request from 'supertest'; +import { PrismaService } from '../prisma/prisma.service'; +import { ApiKeysController } from './api-keys.controller'; +import { ApiKeysService } from './api-keys.service'; + +const integration = process.env.CORPORATE_TEST_DATABASE_URL + ? describe + : describe.skip; +integration( + 'human-only key administration / real key authentication and PostgreSQL', + () => { + let app: INestApplication, db: PrismaService, service: ApiKeysService; + let rawKey: string, target: string; + const secret = 'isolated-test-jwt'; + beforeAll(async () => { + const url = new URL(process.env.CORPORATE_TEST_DATABASE_URL!); + if (url.hostname !== '127.0.0.1' || url.pathname !== '/corporate_test') + throw new Error('Disposable DB required'); + db = new PrismaClient({ + datasources: { db: { url: url.toString() } }, + }) as PrismaService; + passport.use( + 'jwt', + new Strategy( + { + jwtFromRequest: ExtractJwt.fromAuthHeaderAsBearerToken(), + secretOrKey: secret, + }, + (p, done) => done(null, { id: p.sub, role: p.role }), + ), + ); + const module = await Test.createTestingModule({ + controllers: [ApiKeysController], + providers: [ApiKeysService, { provide: PrismaService, useValue: db }], + }).compile(); + service = module.get(ApiKeysService); + app = module.createNestApplication(); + await app.listen(0, '127.0.0.1'); + rawKey = ( + await service.create({ + name: 'security-fixture-admin', + scopes: ['admin'], + }) + ).rawKey; + target = ( + await service.create({ + name: 'security-fixture-target', + scopes: ['read'], + }) + ).apiKey.id; + }); + afterAll(async () => { + await db?.apiKey.deleteMany({ + where: { name: { startsWith: 'security-fixture' } }, + }); + await app?.close(); + await db?.$disconnect(); + passport.unuse('jwt'); + }); + it.each(['get', 'post', 'patch', 'delete'] as const)( + 'denies %s to authenticated admin API key without mutating keys', + async (method) => { + const before = await db.apiKey.count(); + const path = + '/admin/api-keys' + + (method === 'patch' + ? `/${target}/toggle` + : method === 'delete' + ? `/${target}` + : ''); + await request(app.getHttpServer()) + [method](path) + .set('x-api-key', rawKey) + .send( + method === 'post' + ? { name: 'security-fixture-forged-reviewer', scopes: ['admin'] } + : {}, + ) + .expect(403); + expect(await db.apiKey.count()).toBe(before); + expect( + (await db.apiKey.findUniqueOrThrow({ where: { id: target } })).status, + ).toBe('ACTIVE'); + }, + ); + it('retains human admin CRUD and rejects nonadmin humans and wildcard keys', async () => { + const auth = + 'Bearer ' + sign({ sub: 'fixture-human', role: 'Admin' }, secret); + const created = await request(app.getHttpServer()) + .post('/admin/api-keys') + .set('Authorization', auth) + .send({ name: 'security-fixture-human', scopes: ['read'] }) + .expect(201); + const id = created.body.data.apiKey.id; + await request(app.getHttpServer()) + .get('/admin/api-keys') + .set('Authorization', auth) + .expect(200); + await request(app.getHttpServer()) + .patch(`/admin/api-keys/${id}/toggle`) + .set('Authorization', auth) + .expect(200); + await request(app.getHttpServer()) + .delete(`/admin/api-keys/${id}`) + .set('Authorization', auth) + .expect(200); + await request(app.getHttpServer()) + .get('/admin/api-keys') + .set( + 'Authorization', + 'Bearer ' + sign({ sub: 'fixture-user', role: 'USER' }, secret), + ) + .expect(403); + const wildcard = await service.create({ + name: 'security-fixture-wildcard', + scopes: ['*'], + }); + expect((await service.validateKey(wildcard.rawKey)).role).toBe('USER'); + }); + }, +); diff --git a/backend/src/admin/hermes/corporate-policy.ts b/backend/src/admin/hermes/corporate-policy.ts index 08fb08c0..9d8e1cec 100644 --- a/backend/src/admin/hermes/corporate-policy.ts +++ b/backend/src/admin/hermes/corporate-policy.ts @@ -143,6 +143,54 @@ export function canonical(value: any): string { ); return JSON.stringify(value); } +/** Public projection must also cover nested evidence and child records. */ +export function publicData(value: any): any { + if (value instanceof Date) return value; + if (Array.isArray(value)) return value.map(publicData); + if (value && typeof value === 'object') + return Object.fromEntries( + Object.entries(value) + .filter(([key]) => key !== 'claimToken') + .map(([key, item]) => [key, publicData(item)]), + ); + return value; +} +export function httpsUrl(value: unknown): string { + const raw = text(value, 2000); + try { + if (!/^https:\/\/[a-z0-9]/i.test(raw) || /[\s\\]/.test(raw)) throw new Error(); + const u = new URL(raw); + const host = u.hostname.toLowerCase(); + if ( + u.protocol !== 'https:' || + u.username || + u.password || + !/^(?:[a-z0-9](?:[a-z0-9-]{0,61}[a-z0-9])?\.)+[a-z]{2,63}$/.test(host) || + host === 'localhost' || + host.endsWith('.localhost') || + /(^|\.)example\.(com|org|net)$/.test(host) + ) + throw new Error(); + return raw; + } catch { + throw new BadRequestException('Valid HTTPS host URL required'); + } +} +export function timestamp(value: unknown, message: string): Date { + if ( + typeof value !== 'string' || + !/^\d{4}-\d{2}-\d{2}T\d{2}:\d{2}:\d{2}(?:\.\d{1,3})?Z$/.test(value) + ) + throw new BadRequestException(message); + const date = new Date(value); + if ( + !Number.isFinite(date.getTime()) || + date.getTime() > Date.now() || + date.toISOString().slice(0, 19) !== value.slice(0, 19) + ) + throw new BadRequestException(message); + return date; +} export function evidenceInput(input: unknown) { const b = object(input, [ 'claimToken', @@ -153,16 +201,14 @@ export function evidenceInput(input: unknown) { 'result', ]); const uri = text(b.artifactUri, 2000); - if ( - !/^(https:\/\/|urn:sha256:)/.test(uri) || - /example\.(com|org)|localhost|127\.0\.0\.1/.test(uri) - ) - throw new BadRequestException( - 'Evidence locator must be a real HTTPS artifact or content digest', - ); + const sha = text(b.sha256, 64); if (!/^[a-f0-9]{64}$/.test(sha)) throw new BadRequestException('Invalid digest'); + if (uri.startsWith('urn:')) { + if (uri !== 'urn:sha256:' + sha) + throw new BadRequestException('Digest locator mismatch'); + } else httpsUrl(uri); return { claimToken: uuid(b.claimToken), artifactUri: uri, diff --git a/backend/src/admin/hermes/corporate.integration.spec.ts b/backend/src/admin/hermes/corporate.integration.spec.ts index 545043cd..a1301fc1 100644 --- a/backend/src/admin/hermes/corporate.integration.spec.ts +++ b/backend/src/admin/hermes/corporate.integration.spec.ts @@ -80,6 +80,264 @@ integration('corporate API / disposable PostgreSQL', () => { 'TRUNCATE corporate_operations, corporate_reports, corporate_effects, corporate_reviews, corporate_evidence, corporate_events, corporate_tasks, corporate_goals, corporate_roadmaps, corporate_sources, corporate_research CASCADE', ); }); + it('rejects children after a parent claim commits while child creation waits on its row lock', async () => { + const parent = (await post('tasks', input).expect(201)).body; + let release!: () => void, locked!: () => void; + const ready = new Promise((r) => (locked = r)); + const hold = new Promise((r) => (release = r)); + const claiming = db.$transaction(async (tx) => { + await tx.$queryRaw`SELECT id FROM corporate_tasks WHERE id=${parent.id}::uuid FOR UPDATE`; + await tx.corporateTask.update({ + where: { id: parent.id }, + data: { + status: 'IN_PROGRESS', + claimToken: key(), + assignedAgent: 'executor', + leasedUntil: new Date(Date.now() + 60000), + }, + }); + locked(); + await hold; + }); + await ready; + const pending = post('tasks', { ...input, parentId: parent.id }).then( + (r) => r, + ); + try { + // Observe actual competing PostgreSQL lock wait, not a timing-only race. + let waiting = false; + for (let i = 0; i < 100; i++) { + const rows = await db.$queryRaw< + any[] + >`SELECT pid FROM pg_stat_activity WHERE datname=current_database() AND wait_event_type='Lock' AND query LIKE '%corporate_tasks%'`; + if (rows.length) { + waiting = true; + break; + } + await new Promise((r) => setTimeout(r, 10)); + } + expect(waiting).toBe(true); + } finally { + release(); + await claiming; + } + expect((await pending).status).toBe(409); + expect( + await db.corporateTask.count({ where: { parentId: parent.id } }), + ).toBe(0); + }); + it('accepts children on TODO and BLOCKED, which prevents parent claiming', async () => { + for (const status of ['TODO', 'BLOCKED'] as const) { + const parent = (await post('tasks', input).expect(201)).body; + await db.corporateTask.update({ + where: { id: parent.id }, + data: { status }, + }); + const child = ( + await post('tasks', { ...input, parentId: parent.id }).expect(201) + ).body; + expect((await post('claims', {}).expect(201)).body.task.id).toBe( + child.id, + ); + } + }); + it('rejects malformed artifact locators and mismatched digest URNs before persistence', async () => { + const task = (await post('tasks', input).expect(201)).body; + const claim = (await post('claims', {}).expect(201)).body.task; + const body = { + claimToken: claim.claimToken, + artifactUri: '', + sha256: 'a'.repeat(64), + summary: 'receipt', + tool: 'jest', + result: 'passed', + }; + for (const artifactUri of [ + 'https://', + 'https://?x', + 'https:///pubmed.ncbi.nlm.nih.gov/x', + 'https://pubmed.ncbi.nlm.nih.gov./x', + 'https://bad host/x', + 'https://user:pass@host.org/a', + 'https://localhost/a', + 'https://127.1/a', + 'https://[::1]/a', + 'urn:sha256:', + 'urn:sha256:' + 'b'.repeat(64), + ]) { + await post(`tasks/${task.id}/evidence`, { ...body, artifactUri }).expect( + 400, + ); + } + expect(await db.corporateEvidence.count()).toBe(0); + await post(`tasks/${task.id}/evidence`, { + ...body, + artifactUri: 'https://pubmed.ncbi.nlm.nih.gov/123/', + }).expect(201); + }); + it('rejects implicit timestamp coercions in source and effect inputs', async () => { + const service = app.get(CorporateService); + const research = { + title: 'research', + category: 'TREND', + source: 'receipt', + opportunity: 'investigate', + impact: 'LOW', + recommendedAction: 'measure', + cadence: 'MONTHLY', + provenance: { method: 'test', collector: 'fixture', context: 'isolated' }, + sources: [ + { + url: 'https://pubmed.ncbi.nlm.nih.gov/', + title: 'source', + excerpt: 'receipt', + retrievedAt: '', + sha256: 'a'.repeat(64), + }, + ], + }; + for (const time of [ + null, + 0, + false, + [], + '2026-01-01', + '2026-02-30T00:00:00Z', + ]) { + await expect( + Promise.resolve().then(() => + service.research('fixture', key(), { + ...research, + sources: [{ ...research.sources[0], retrievedAt: time }], + }), + ), + ).rejects.toThrow(); + await expect( + Promise.resolve().then(() => + service.effect('fixture', key(), key(), { + metric: 'views', + availability: 'UNAVAILABLE', + source: 'none', + observedAt: time, + }), + ), + ).rejects.toThrow('Invalid observation time'); + } + for (const url of ['https://', 'https://?bad', 'https://bad host']) + await expect( + Promise.resolve().then(() => + service.research('fixture', key(), { + ...research, + sources: [ + { + ...research.sources[0], + retrievedAt: '2026-01-01T00:00:00Z', + url, + }, + ], + }), + ), + ).rejects.toThrow(); + expect(await db.corporateResearch.count()).toBe(0); + }); + it('public reads strip claim tokens recursively while claim and replay retain ownership token', async () => { + const parent = (await post('tasks', input).expect(201)).body; + const child = ( + await post('tasks', { ...input, parentId: parent.id }).expect(201) + ).body; + const op = key(); + const claim = (await post('claims', {}, 'executor', op).expect(201)).body + .task; + expect(claim.claimToken).toBeTruthy(); + expect( + (await post('claims', {}, 'executor', op).expect(201)).body.task + .claimToken, + ).toBe(claim.claimToken); + await post(`tasks/${child.id}/evidence`, { + claimToken: claim.claimToken, + artifactUri: 'urn:sha256:' + 'a'.repeat(64), + sha256: 'a'.repeat(64), + summary: 'receipt', + tool: 'jest', + result: 'passed', + }).expect(201); + for (const path of ['tasks', 'tasks/' + child.id, 'tasks/' + parent.id]) { + const r = await request(app.getHttpServer()) + .get('/admin/hermes/' + path) + .set('x-api-key', 'competitor') + .expect(200); + expect(JSON.stringify(r.body)).not.toContain('claimToken'); + expect(JSON.stringify(r.body)).not.toContain(claim.claimToken); + } + }); + it('bounds detail relations and report snapshots with explicit truncation and immutable replay', async () => { + const task = (await post('tasks', input).expect(201)).body; + await db.corporateEvent.createMany({ + data: Array.from({ length: 105 }, () => ({ + taskId: task.id, + speaker: 'SYSTEM', + speakerName: 'fixture', + step: 'FIXTURE', + content: 'x'.repeat(10000), + payload: { nested: ['x'.repeat(10000)] }, + })), + }); + const detail = await request(app.getHttpServer()) + .get('/admin/hermes/tasks/' + task.id) + .set('x-api-key', 'executor') + .expect(200); + expect(detail.body.logs).toHaveLength(100); + expect(detail.body.relationsMeta.logs).toEqual({ + total: 106, + returned: 100, + limit: 100, + truncated: true, + }); + const op = key(), + body = { day: new Date().toISOString().slice(0, 10), summary: 'bounded' }; + const report = (await post('reports', body, 'executor', op).expect(201)) + .body; + expect(report.snapshot.events).toHaveLength(100); + expect(report.snapshot.meta.events).toEqual({ + total: 106, + returned: 100, + limit: 100, + truncated: true, + }); + expect(report.snapshot.events.every((e: any) => !('payload' in e))).toBe( + true, + ); + expect(report.snapshot.meta.fieldsTruncated).toBe(true); + expect( + Buffer.byteLength(JSON.stringify(report.body ?? report)), + ).toBeLessThan(1000000); + await db.corporateEvent.deleteMany(); + expect( + (await post('reports', body, 'executor', op).expect(201)).body, + ).toEqual(report); + }); + it('rolls back oversized mutation responses instead of persisting huge idempotency values', async () => { + const service = app.get(CorporateService) as any; + const before = await db.corporateTask.count(); + await expect( + service.operation('fixture', 'oversize', key(), {}, async (tx: any) => { + await tx.corporateTask.create({ + data: { + title: 'rollback', + description: 'fixture', + taskCode: key(), + normalizedTitle: 'rollback', + normalizedCode: key(), + department: 'CONTENT_SEO', + createdBy: 'fixture', + }, + }); + return { value: 'x'.repeat(1100000) }; + }), + ).rejects.toThrow('Operation response exceeds limit'); + expect(await db.corporateTask.count()).toBe(before); + expect(await db.corporateOperation.count()).toBe(0); + }); it('auth, UI list contract, normalized search, immutable idempotent replay', async () => { await request(app.getHttpServer()).get('/admin/hermes/tasks').expect(401); await post('tasks', input, 'unscoped').expect(403); diff --git a/backend/src/admin/hermes/corporate.service.ts b/backend/src/admin/hermes/corporate.service.ts index 3579bbb0..77e6de09 100644 --- a/backend/src/admin/hermes/corporate.service.ts +++ b/backend/src/admin/hermes/corporate.service.ts @@ -9,9 +9,12 @@ import { createHash, randomUUID } from 'crypto'; import { PrismaService } from '../../prisma/prisma.service'; import { canonical, + publicData, choice, departments, evidenceInput, + httpsUrl, + timestamp, meta, normalizeSearch, object, @@ -50,7 +53,10 @@ export class CorporateService { return prior.response; } const result = await fn(tx); - const response = JSON.parse(JSON.stringify(result)); + const serialized = JSON.stringify(result); + if (Buffer.byteLength(serialized, 'utf8') > 1000000) + throw new BadRequestException('Operation response exceeds limit'); + const response = JSON.parse(serialized); await tx.corporateOperation.create({ data: { key: scoped, payloadHash: hash, response }, }); @@ -112,32 +118,59 @@ export class CorporateService { take: p.limit, orderBy: [{ [p.sortBy]: p.sortOrder }, { id: 'asc' }], }); - return { data, meta: meta(total, p.page, p.limit) }; + return publicData({ data, meta: meta(total, p.page, p.limit) }); }, { isolationLevel: Prisma.TransactionIsolationLevel.RepeatableRead }, ); } async detail(id: string) { uuid(id); - const task = await this.db.corporateTask.findUnique({ - where: { id }, - include: { - logs: { orderBy: { timestamp: 'asc' } }, - evidence: true, - reviews: true, - effects: true, - children: true, + return this.db.$transaction( + async (tx) => { + const order = { id: 'asc' as const }; + const task = await tx.corporateTask.findUnique({ + where: { id }, + include: { + logs: { take: 100, orderBy: [{ timestamp: 'asc' }, order] }, + evidence: { take: 100, orderBy: order }, + reviews: { take: 100, orderBy: order }, + effects: { take: 100, orderBy: order }, + children: { take: 100, orderBy: order }, + _count: { + select: { + logs: true, + evidence: true, + reviews: true, + effects: true, + children: true, + }, + }, + }, + }); + if (!task) throw new NotFoundException('Task not found'); + const { _count, ...data } = task; + const relationsMeta = Object.fromEntries( + Object.entries(_count).map(([name, total]) => [ + name, + { + total, + returned: Math.min(total, 100), + limit: 100, + truncated: total > 100, + }, + ]), + ); + return publicData({ ...data, relationsMeta }); }, - }); - if (!task) throw new NotFoundException('Task not found'); - return task; + { isolationLevel: Prisma.TransactionIsolationLevel.RepeatableRead }, + ); } create(actor: string, key: string, input: unknown) { const b = taskInput(input); return this.operation(actor, 'create-task', key, b, async (tx) => { if (b.parentId) { const parent = await this.lock(tx, b.parentId); - if (!['TODO', 'IN_PROGRESS', 'BLOCKED'].includes(parent.status)) + if (!['TODO', 'BLOCKED'].includes(parent.status)) throw new ConflictException('Parent no longer accepts children'); } const code = 'TSK-' + randomUUID(); @@ -347,7 +380,7 @@ export class CorporateService { ? { include: { goals: true } } : {}), }); - return { data, meta: meta(total, p.page, p.limit) }; + return publicData({ data, meta: meta(total, p.page, p.limit) }); }, { isolationLevel: Prisma.TransactionIsolationLevel.RepeatableRead }, ); @@ -374,9 +407,9 @@ export class CorporateService { 'retrievedAt', 'sha256', ]); - const url = text(s.url, 2000), + const url = httpsUrl(s.url), sha256 = text(s.sha256, 64), - retrievedAt = new Date(s.retrievedAt); + retrievedAt = timestamp(s.retrievedAt, 'Invalid source time'); if ( !url.startsWith('https://') || !/^[a-f0-9]{64}$/.test(sha256) || @@ -531,7 +564,7 @@ export class CorporateService { (b.observed != null || b.baseline != null) ) throw new BadRequestException('Unavailable is not zero'); - const observedAt = new Date(b.observedAt); + const observedAt = timestamp(b.observedAt, 'Invalid observation time'); if ( !Number.isFinite(observedAt.getTime()) || observedAt.getTime() > Date.now() @@ -571,8 +604,18 @@ export class CorporateService { return this.operation(actor, 'report', key, b, async (tx) => { const start = new Date(day + 'T00:00:00Z'), end = new Date(start.getTime() + 86400000); + const taskWhere = { updatedAt: { gte: start, lt: end } }; + const eventWhere = { timestamp: { gte: start, lt: end } }; + const effectWhere = { createdAt: { gte: start, lt: end } }; + const totals = { + tasks: await tx.corporateTask.count({ where: taskWhere }), + events: await tx.corporateEvent.count({ where: eventWhere }), + effects: await tx.corporateEffect.count({ where: effectWhere }), + }; const tasks = await tx.corporateTask.findMany({ - where: { updatedAt: { gte: start, lt: end } }, + where: taskWhere, + take: 100, + orderBy: [{ updatedAt: 'asc' }, { id: 'asc' }], select: { id: true, taskCode: true, @@ -583,14 +626,75 @@ export class CorporateService { }, }); const events = await tx.corporateEvent.findMany({ - where: { timestamp: { gte: start, lt: end } }, - orderBy: { timestamp: 'asc' }, + where: eventWhere, + take: 100, + orderBy: [{ timestamp: 'asc' }, { id: 'asc' }], + select: { + id: true, + taskId: true, + timestamp: true, + speaker: true, + speakerName: true, + step: true, + content: true, + }, }); const effects = await tx.corporateEffect.findMany({ - where: { createdAt: { gte: start, lt: end } }, + where: effectWhere, + take: 100, + orderBy: [{ createdAt: 'asc' }, { id: 'asc' }], + select: { + id: true, + taskId: true, + metric: true, + availability: true, + baseline: true, + observed: true, + source: true, + observedAt: true, + createdAt: true, + }, }); + let fieldsTruncated = false; + const project = (rows: any[]) => + rows.map((row) => + Object.fromEntries( + Object.entries(row).map(([name, value]) => { + if (typeof value === 'string' && value.length > 1000) { + fieldsTruncated = true; + return [name, value.slice(0, 1000)]; + } + return [name, value]; + }), + ), + ); + const bounded = { + tasks: project(tasks), + events: project(events), + effects: project(effects), + }; + const counts = Object.fromEntries( + Object.entries(totals).map(([name, total]) => [ + name, + { + total, + returned: Math.min(total, 100), + limit: 100, + truncated: total > 100, + }, + ]), + ); const snapshot = JSON.parse( - JSON.stringify({ timezone: 'UTC', tasks, events, effects }), + JSON.stringify({ + timezone: 'UTC', + ...bounded, + meta: { + ...counts, + fieldsTruncated, + stringLimit: 1000, + eventPayloadsOmitted: true, + }, + }), ); return tx.corporateReport.create({ data: { day, summary, snapshot, createdBy: actor }, diff --git a/backend/src/common/guards/human-admin.guard.ts b/backend/src/common/guards/human-admin.guard.ts new file mode 100644 index 00000000..c060446b --- /dev/null +++ b/backend/src/common/guards/human-admin.guard.ts @@ -0,0 +1,17 @@ +import { + CanActivate, + ExecutionContext, + ForbiddenException, + Injectable, +} from '@nestjs/common'; + +/** Key management is a human-only control plane, never delegated by API scope. */ +@Injectable() +export class HumanAdminGuard implements CanActivate { + canActivate(context: ExecutionContext): boolean { + const user = context.switchToHttp().getRequest().user; + if (!user || user.isApiKey || !['Admin', 'SUPER_ADMIN'].includes(user.role)) + throw new ForbiddenException('Human administrator required'); + return true; + } +}